New issue
Advanced search Search tips

Issue 640808 link

Starred by 2 users
Status: Verified
Owner:
derat@chromium.org
Closed: Aug 2016
Cc:
abodenha@chromium.org
tbuck...@chromium.org
est...@chromium.org
osh...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Incognito popups' titles are nearly invisible

Project Member Reported by derat@chromium.org, Aug 24 2016 
Google Chrome	52.0.2743.116 (Official Build) (32-bit)
Revision	9115ecad1cae66fd5fe52bd9120af643384fd6f3-refs/branch-heads/2743@{#728}
Platform	8350.68.0 (Official Build) stable-channel veyron_speedy

(Still present on a recent M54 build, though.)

1. Open an incognito window and create a popup (e.g. via http://www.quirksmode.org/js/popup.html).
2. Try to read the popup window's title.

When the popup is unfocused, its title is black on dark gray. It's really hard to read.

When the popup is focused, its title is black on *very* dark gray. It's basically impossible to read.

Incognito tabs use a white or near-white text color. Probably we should use the same color for incognito popups' titles instead of black.
unfocused.png
17.6 KB View Download
focused.png
13.8 KB View Download

Comment 1 by derat@chromium.org, Aug 25 2016

Cc: tbuck...@chromium.org est...@chromium.org
Components: UI>Browser>Themes
It looks like this is coming from chrome/browser/ui/views/frame/browser_header_painter_ash.cc, where kWindowTitleTextColor is hardcoded to SkColorSetRGB(40, 40, 40).

I'm not sure of the proper way to fix this. Hardcoding a different near-white color for incognito windows would presumably break themes that have light backgrounds (assuming that those override the incognito frame background, which I think they do).

Do themes support setting popup (and app?) windows' text color(s)?

(I don't know anything about the default theme on Chrome OS. Hopefully someone else does.)

Comment 2 by est...@chromium.org, Aug 26 2016

Cc: sgabr...@chromium.org
Popup windows don't get browser themes so we only have to worry about the classic theme. We can/should probably just change the use of kWindowTitleTextColor to is_incognito_ ? kIncognitoWindowTitleTextColor : kWindowTitleTextColor;

Also the reason this only comes up on cros is that elsewhere we use native system frames for popups.

+sgabriel can tell us what those colors should be.

Comment 3 by sgabr...@chromium.org, Aug 27 2016 

Unless I'm missing something, seems like title should be the same color as domain, in this case #FFF.

Comment 4 by est...@chromium.org, Aug 27 2016 

sgtm

Comment 5 by derat@chromium.org, Aug 29 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d40669ec06f3729b0c7099befda0f98f800863

commit a5d40669ec06f3729b0c7099befda0f98f800863
Author: derat <derat@chromium.org>
Date: Tue Aug 30 04:32:52 2016

Make title text white in ash incognito popup window frames.

In ash, incognito popup windows have dark-gray frames. Make
their title text white rather than dark-gray so it can be
read.

BUG= 640808 
TEST=manual: both regular and incognito popup windows
     contain readable title text

Review-Url: https://codereview.chromium.org/2290703002
Cr-Commit-Position: refs/heads/master@{#415098}

[modify] https://crrev.com/a5d40669ec06f3729b0c7099befda0f98f800863/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/a5d40669ec06f3729b0c7099befda0f98f800863/chrome/browser/ui/views/frame/browser_header_painter_ash.h

Comment 7 by derat@chromium.org, Aug 30 2016

Status: Fixed (was: Started)

Comment 8 by sdantul...@chromium.org, Oct 21 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Pop-up titles are white in color and clearly visible
►

Sign in to add a comment