AVDA crashes if it's destructed before the construction thread is started |
||||
Issue descriptionIn my previous change I forgot to check that the thread is running before dereferencing it's task runner: https://codereview.chromium.org/2245333004 This crashes if AVDA fails in Initialize before StartThread() (or Initialize is never called). Issue was found by telemetry runs failing in: https://bugs.chromium.org/p/chromium/issues/detail?id=640727
,
Aug 24 2016
,
Aug 24 2016
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/970f2b01f45ed574d12ffe9652191c7cf2c2f5fd commit 970f2b01f45ed574d12ffe9652191c7cf2c2f5fd Author: watk <watk@chromium.org> Date: Thu Aug 25 19:17:20 2016 Fix a crash in AVDA when dereferencing a null task runner Previously AVDAManager::StopThread() made the incorrect assumption that the construction thread was running before using its task runner. Now we only use the task runner when the the thread is running. BUG= 640806 TEST=run the webrtc.peerconnection benchmark Review-Url: https://codereview.chromium.org/2277083002 Cr-Commit-Position: refs/heads/master@{#414503} [modify] https://crrev.com/970f2b01f45ed574d12ffe9652191c7cf2c2f5fd/media/gpu/android_video_decode_accelerator.cc
,
Aug 25 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yini...@chromium.org
, Aug 24 2016