New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640805 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC++: Transparent surfaces are composited by Chrome

Project Member Reported by reve...@chromium.org, Aug 24 2016

Issue description

Looks like a regression since switching to cc::surfaces. We're now compositing one fullscreen transparent buffer above everything when ARC++ is enabled. This has a major performance impact on low bandwidth devices.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d54b85fbc32bd0d19e1741677a296e25fd47c7

commit e2d54b85fbc32bd0d19e1741677a296e25fd47c7
Author: reveman <reveman@chromium.org>
Date: Thu Aug 25 00:30:38 2016

exo: Avoid creating transparent texture quads.

The surface is fully transparent when alpha is 0 and we can then
avoid to create a texture quad completely. Failing to do so
currently results in unnecessary compositing.

BUG= 640805 
TEST=exo_unittests

Review-Url: https://codereview.chromium.org/2277833004
Cr-Commit-Position: refs/heads/master@{#414220}

[modify] https://crrev.com/e2d54b85fbc32bd0d19e1741677a296e25fd47c7/components/exo/surface.cc

Labels: Merge-Request-53
Cc: bhthompson@chromium.org
This change only effects ChromeOS devices with ARC++ and provides a critical performance improvement on those devices.

Comment 5 by dimu@chromium.org, Aug 25 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
Cc: keta...@chromium.org
Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 cros.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b50ca09664b21db2a2abb04d76199daf347b3bd

commit 8b50ca09664b21db2a2abb04d76199daf347b3bd
Author: David Reveman <reveman@chromium.org>
Date: Tue Aug 30 20:59:59 2016

exo: Avoid creating transparent texture quads.

The surface is fully transparent when alpha is 0 and we can then
avoid to create a texture quad completely. Failing to do so
currently results in unnecessary compositing.

BUG= 640805 
TEST=exo_unittests

Review-Url: https://codereview.chromium.org/2277833004
Cr-Commit-Position: refs/heads/master@{#414220}
(cherry picked from commit e2d54b85fbc32bd0d19e1741677a296e25fd47c7)

Review URL: https://codereview.chromium.org/2293223002 .

Cr-Commit-Position: refs/branch-heads/2785@{#794}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/8b50ca09664b21db2a2abb04d76199daf347b3bd/components/exo/surface.cc

Status: Fixed (was: Assigned)

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment