New issue
Advanced search Search tips

Issue 640773 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 640772



Sign in to add a comment

Port ResizeShadow and the like to mash

Project Member Reported by sky@chromium.org, Aug 24 2016

Issue description

And hook it up in WmWindowMus::Show/HideResizeWindow.

It's likely the case this won't work until 640772 is fixed. By that I mean once implemented I don't think anything will trigger the show until 640772 is fixed.
 
Components: MUS
Labels: Proj-Mustash
Components: Internals>MUS

Comment 5 by sky@chromium.org, Feb 1 2017

Blocking: 687656

Comment 6 by sky@chromium.org, Mar 7 2017

This is still an issue. See WmWindow::ShowResizeShadow and HideResizeShadow.

Comment 7 by varkha@chromium.org, May 31 2017

The implementations have moved to ash/wm/wm_toplevel_window_event_handler.cc in r474757 so no longer blocking  issue 687656 .

Comment 8 by varkha@chromium.org, May 31 2017

Blocking: -687656
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Status: WontFix (was: Untriaged)
ResizeShadow is now used. All the code referenced here has been removed.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df313f35745a6d1ad95589ee328cf893aaab4d0

commit 4df313f35745a6d1ad95589ee328cf893aaab4d0
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 17:06:25 2018

chromeos: removes some dead code

MASH_DEPRECATED is never set anymore.

BUG= 640773 
TEST=none

Change-Id: Iab913023f56e7f832cb987b10b5725d55ccc1ead
Reviewed-on: https://chromium-review.googlesource.com/1176072
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583287}
[modify] https://crrev.com/4df313f35745a6d1ad95589ee328cf893aaab4d0/ash/wm/wm_toplevel_window_event_handler.cc

Sign in to add a comment