New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640759 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Work out dependencies between offline page model and request coordinator

Project Member Reported by fgor...@chromium.org, Aug 24 2016

Issue description

Work out dependencies between offline page model and request coordinator

We need to clarify what the dependencies between the two should be and which one should be constructed/destroyed first.

This is to properly handle the user data objects that may hold pointers to both, like download UI adapter.
 
Description: Show this description

Comment 2 by dim...@chromium.org, Aug 29 2016

One concern is about shutdown sequence and us keeping raw pointers.
Cc: dim...@chromium.org
Owner: fgor...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Work out dependencies between offline page model and request coordinator (was: Work out dependencies between offline page mode and request coordinator)

Comment 5 by chili@chromium.org, Jan 19 2017

Cc: chili@chromium.org
Would this be considered fixed now that we have an explicit DependsOn(OfflinePageModel) clause in RequestCoordinatorFactory? Or do we need to do something more?

https://cs.chromium.org/chromium/src/chrome/browser/android/offline_pages/request_coordinator_factory.cc?rcl=0&l=40
Labels: OS-Android
Status: Fixed (was: Assigned)
Solved by https://codereview.chromium.org/2635633002

Sign in to add a comment