Work out dependencies between offline page model and request coordinator |
|||||
Issue descriptionWork out dependencies between offline page model and request coordinator We need to clarify what the dependencies between the two should be and which one should be constructed/destroyed first. This is to properly handle the user data objects that may hold pointers to both, like download UI adapter.
,
Aug 29 2016
One concern is about shutdown sequence and us keeping raw pointers.
,
Sep 7 2016
,
Jan 9 2017
,
Jan 19 2017
Would this be considered fixed now that we have an explicit DependsOn(OfflinePageModel) clause in RequestCoordinatorFactory? Or do we need to do something more? https://cs.chromium.org/chromium/src/chrome/browser/android/offline_pages/request_coordinator_factory.cc?rcl=0&l=40
,
Jan 19 2017
Solved by https://codereview.chromium.org/2635633002 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fgor...@chromium.org
, Aug 29 2016