New issue
Advanced search Search tips

Issue 640740 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

In git cl try, support triggering jobs on builders on different masters with one command.

Project Member Reported by qyears...@chromium.org, Aug 24 2016

Issue description

Currently, if I try to start try jobs for builders on different masters in one command without specifying masters:

    git cl try -b android_blink_rel -b win10_blink_rel

I get:

    git cl: error: Tryserver master cannot be found because: The builders do not belong to the same master.
    Please manually specify the tryserver master, e.g. "-m tryserver.chromium.linux".

Using the same command to trigger a try job on one builder works.

But, if git-cl can figure out the master (or buildbucket bucket) given just a builder name then it should be possible to start a set of try bots just given builder names as long as all of the builder names are unique across masters.

In order to do this, git cl try may need to add try jobs to multiple Buildbucket buckets.
 
Note, the relevant part of git_cl.py to look at is around https://cs.chromium.org/chromium/tools/depot_tools/git_cl.py?l=4740.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/123a468d14c58e78685f4d2bf166b4c285870f2d

commit 123a468d14c58e78685f4d2bf166b4c285870f2d
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Oct 26 16:12:17 2016

git cl try: support multiple bots from different masters without specifying master.

It might be good to make this change after the refactoring CL http://crrev.com/2442153002.

BUG= 640740 

Review-Url: https://codereview.chromium.org/2439293002

[modify] https://crrev.com/123a468d14c58e78685f4d2bf166b4c285870f2d/git_cl.py
[modify] https://crrev.com/123a468d14c58e78685f4d2bf166b4c285870f2d/tests/git_cl_test.py

Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment