Issue metadata
Sign in to add a comment
|
Where is the cc::OutputSurface supposed to die? |
||||||||||||||||||||||
Issue descriptionThe comment on the class says that once passed to the compositor thread and bound to its client, it will be deleted on the same thread. We also read |client_| in the dtor and detach if its still there. But its actually deleted on the main thread and the compositor thread only holds a weak reference. So which one is it supposed to be?
,
Aug 24 2016
The DetachFromClient happens on the compositor thread. I want it to die there but it doesn't because the worker context is bound to the main thread and it needs to be destroyed there. Consider the OS dead before BindToClient and after DetachFromClient. That's why weakptrs are invalidated explicitly in there.
,
Aug 24 2016
That comment used to be true, you can find the CL that added sharing the worker context to see where it changed. And I'm trying to fix it.
,
Aug 24 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vmp...@chromium.org
, Aug 24 2016Owner: danakj@chromium.org