New issue
Advanced search Search tips

Issue 640700 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 640637
issue 642776



Sign in to add a comment

Add a flag to make Chrome behave like Edge for PointerEvents

Project Member Reported by mustaq@chromium.org, Aug 24 2016

Issue description

Chrome implementation of PointerEvent is different from Edge in two ways:
A. No hit-testing while captured:
  https://github.com/w3c/pointerevents/issues/61
B. Implicit capture of touch:
  https://github.com/w3c/pointerevents/pull/129

So far, we haven't found any compat issues around them.

To make it easy to test the behavior differences, both Edge & Chrome decided to possibly include a "mode-switch" flag provided it's easy to implement. See the details in the notes:
https://docs.google.com/document/d/1b8aJOJcGXakstFJslKl87QwvlFHhHwGbQfJwnUTBBHg/edit?usp=sharing

- I think adding two separate switches for A & B should be better: will let us easily pin-point the root cause if we find some site broken.

- As we discussed today, we will avoid adding a virtual test suite because this is for manual testing only---doesn't justify the cost of virtual suite maintenance overhead.
 

Comment 1 by mustaq@chromium.org, Aug 26 2016

Blocking: 640637

Comment 2 by rbyers@chromium.org, Aug 31 2016

Note that these flags will be removed at some point not long after we ship pointer events (when all debate about the API design has concluded).
Blocking: 642776
I created an issue for removing these flags to make sure we do that after designs debates.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d8e3857dc1ad98b96493297bf3a95fa838eeb17

commit 8d8e3857dc1ad98b96493297bf3a95fa838eeb17
Author: nzolghadr <nzolghadr@chromium.org>
Date: Thu Sep 01 14:27:53 2016

Adding chrome flag to disable implicit capture

This change adds a flag to disable implicit
touch pointer events. So that when the touch
goes down it does not gets captured to that
element. Note that it doesn't change the touch
events and it only affects the pointer events.

BUG= 640700 

Review-Url: https://codereview.chromium.org/2283013002
Cr-Commit-Position: refs/heads/master@{#415950}

[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/chrome/app/generated_resources.grd
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/chrome/browser/about_flags.cc
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/content/child/runtime_features.cc
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/content/public/common/content_features.cc
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/content/public/common/content_features.h
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/8d8e3857dc1ad98b96493297bf3a95fa838eeb17/third_party/WebKit/public/web/WebRuntimeFeatures.h

Cc: nzolghadr@chromium.org dtapu...@chromium.org
 Issue 632393  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbc77fb19301347fe7d062691ad20d82d5eb865

commit ebbc77fb19301347fe7d062691ad20d82d5eb865
Author: nzolghadr <nzolghadr@chromium.org>
Date: Mon Sep 12 20:58:00 2016

Conditional hittesting and sending boundary events for captured pointer events

This CL adds the support sending boundary events for captured
pointer events if needed when pointerEventV1SpecCapturingEnabled
flag is enabled. Although it might not have captured all edge
cases but it does satisfy the basic needs and normal
use cases which suffices the testing need.
This CL does not change any behavior when the flag is off and
it is only for testing purposes when the flag is on.
Removal of this flag is tracked in  crbug.com/642776 .

BUG= 640700 

Review-Url: https://codereview.chromium.org/2326653003
Cr-Commit-Position: refs/heads/master@{#418039}

[modify] https://crrev.com/ebbc77fb19301347fe7d062691ad20d82d5eb865/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/ebbc77fb19301347fe7d062691ad20d82d5eb865/third_party/WebKit/Source/core/input/PointerEventManager.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment