New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640687 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 612701
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 612701



Sign in to add a comment

Devtools changes behavior of memory cache reload when open

Project Member Reported by allada@chromium.org, Aug 24 2016

Issue description

When devtools is open memory cache is partially disabled for the initial reload event, however when devtools is closed a reload will reuse memory cache.
 
Blocking: 612701

Comment 2 by allada@chromium.org, Aug 25 2016

Blocking: 612701

Comment 3 by allada@chromium.org, Aug 25 2016

Blocking: -612701
Mergedinto: 612701
Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce98e6c4a756a41f57ff444a40267a66f52e91e8

commit ce98e6c4a756a41f57ff444a40267a66f52e91e8
Author: allada <allada@chromium.org>
Date: Fri Sep 09 19:34:56 2016

[Devtools] Fix reload behavior when devtools is open

Fixed a bug where devtools was changing the reload behavior of
chrome while it was open. This patch makes devtools follow
the same behavior chrome does when refreshing.

The memory cache was being ignored in the case when devtools was
open devtools consumes the reload events and dispatches them to
devtools front-end for directives on what to do. Front end was then
dispatching a reload event back to browser but the directive that
devtools was instructing was to ignore memory cache (same behavior
that window.location.reload() would use), however if the user was
to reload with devtools closed it would try and use the items in
memory cache if available.

Patch worth noting: https://codereview.chromium.org/1975753006

R=dgozman
BUG= 640687 

Review-Url: https://codereview.chromium.org/2274233002
Cr-Commit-Position: refs/heads/master@{#417669}

[modify] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js
[add] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/reload-memory-cache-expected.txt
[add] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/reload-memory-cache.html
[modify] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector/extensions-useragent.html
[modify] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion-expected.txt
[modify] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html
[modify] https://crrev.com/ce98e6c4a756a41f57ff444a40267a66f52e91e8/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Sign in to add a comment