New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640678 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615892



Sign in to add a comment

System tray focus is not drawn correctly

Project Member Reported by yiyix@chromium.org, Aug 24 2016

Issue description

Version: 54.0.2837.0

What steps will reproduce the problem?
(1) Set ash-md flag to EXPERIMENTAL
(2) Locked the screen using Search + L or ctrl+shift+L
(3) keep pressing tab, the blue rectangle around the system tray is not draw correctly.

What is the expected output?
A blue rectangle is shown and highlight the system tray.

What do you see instead?
A blue rectangle is shown and cut through the user profile picture.

Please refer to the picture for details.
 

Comment 1 by yiyix@chromium.org, Aug 24 2016

Screenshot from 2016-08-24 13:51:20.png
4.1 KB View Download

Comment 2 by yiyix@chromium.org, Aug 24 2016

Cc: tdander...@chromium.org
Labels: Proj-MaterialDesign-CrOS OS-Chrome
Yi, is this the same as  issue 640246  ?

Comment 4 by yiyix@chromium.org, Aug 29 2016

Components: UI>Shell>Shelf
@tdanderson, In 640246, the blue rect is never drawn for both md and non-md when system tray is in focus. In this issue, the md version of the blue rect is not properly draw. 
Blocking: 615892
Cc: -tdander...@chromium.org
Owner: tdander...@chromium.org
Status: Assigned (was: Untriaged)
Cc: tdander...@chromium.org
Labels: -Pri-3 M-56 Pri-2
Owner: alemate@chromium.org
Handing to alemate@ as this is specific to the shelf on the lock/login screen.
Cc: alemate@chromium.org zalcorn@chromium.org
Labels: ReleaseBlock-Stable
Owner: xiaoyinh@chromium.org
Status: Started (was: Assigned)
CL: https://codereview.chromium.org/2513823002/

Please find the attached image to see how it looks after this change.
after_change1.png
2.2 MB View Download
after_change2.png
2.2 MB View Download
I'm a bit confused, actually. When I'm logged in I never see a focus rect on the system tray, with or without your CL applied. I'm using alt+shift+L and tabbing; I only ever see focus rects on the shelf (app) icons. How did you get to the state in the second screenshot?

Also, when I tab through on the lock screen, I see a focus rect on the notification center too (which with your change looks cut off on one side). But when I'm logged in I never see a focus rect on the notification center or any of the other tray items (e.g., opt-in IME menu, VK button).
RE #9: After signin, I was using ctrl+F1 to navigate focus to the system tray, then use tab to switch focus between different trays(system tray, notification ceter, keyboard etc.)
You can do the same thing to navigate focus to shelf buttons(apps), which draw their focus rectangle in a different place. See https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_button.cc?rcl=0&l=472

My intent is to tweak focus rectangle of trays because right now they all looks a little short(just like system tray). 

Summary: System tray focus is not drawn correctly (was: On MD Locked state screen, system tray focus is not drawn correctly)
Changing the title of this bug because it also reproduces when logged in. When logged in you need to use ctrl+F1 (back arrow) in order to get the focus rect on the system tray and other tray items (VK button, opt-in IME button, notification center, etc).
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 21 2016

Labels: Merge-Request-56
Labels: -Merge-Request-56
I'll re-request the merge once this hits canary and I have verified it.
Labels: Merge-Request-56
Sorry, changed my mind from #15. Still waiting for this to make it to canary for verification but let's re-apply the label to get merge permission in the meanwhile.

Comment 17 by dimu@chromium.org, Nov 25 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Verified on 57.0.2933.0 canary. Performing the merge now.
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd

commit 12bb3fd38e5b5b815ddf8d586fe040c750fed2dd
Author: Terry Anderson <tdanderson@chromium.org>
Date: Mon Nov 28 19:15:05 2016

tweak the focus rectangle of TrayBackgroundView objects

BUG= 640678 
TEST=Manually tested on lock screen and signin screen, also after signin.

Review-Url: https://codereview.chromium.org/2513823002
Cr-Commit-Position: refs/heads/master@{#433662}
(cherry picked from commit dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc)

Review URL: https://codereview.chromium.org/2533903002 .

Cr-Commit-Position: refs/branch-heads/2924@{#118}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/actionable_view.h
[modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/tray_background_view.h

Status: Fixed (was: Started)
Cc: durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org kavvaru@chromium.org tbuck...@chromium.org
 Issue 661906  has been merged into this issue.
Status: Verified (was: Fixed)
Verified on ChromeOS 9000.15.0, 56.0.2924.12

Sign in to add a comment