System tray focus is not drawn correctly |
||||||||||||||||
Issue descriptionVersion: 54.0.2837.0 What steps will reproduce the problem? (1) Set ash-md flag to EXPERIMENTAL (2) Locked the screen using Search + L or ctrl+shift+L (3) keep pressing tab, the blue rectangle around the system tray is not draw correctly. What is the expected output? A blue rectangle is shown and highlight the system tray. What do you see instead? A blue rectangle is shown and cut through the user profile picture. Please refer to the picture for details.
,
Aug 24 2016
,
Aug 29 2016
Yi, is this the same as issue 640246 ?
,
Aug 29 2016
@tdanderson, In 640246, the blue rect is never drawn for both md and non-md when system tray is in focus. In this issue, the md version of the blue rect is not properly draw.
,
Sep 13 2016
,
Nov 16 2016
Handing to alemate@ as this is specific to the shelf on the lock/login screen.
,
Nov 16 2016
,
Nov 18 2016
CL: https://codereview.chromium.org/2513823002/ Please find the attached image to see how it looks after this change.
,
Nov 18 2016
I'm a bit confused, actually. When I'm logged in I never see a focus rect on the system tray, with or without your CL applied. I'm using alt+shift+L and tabbing; I only ever see focus rects on the shelf (app) icons. How did you get to the state in the second screenshot? Also, when I tab through on the lock screen, I see a focus rect on the notification center too (which with your change looks cut off on one side). But when I'm logged in I never see a focus rect on the notification center or any of the other tray items (e.g., opt-in IME menu, VK button).
,
Nov 18 2016
RE #9: After signin, I was using ctrl+F1 to navigate focus to the system tray, then use tab to switch focus between different trays(system tray, notification ceter, keyboard etc.) You can do the same thing to navigate focus to shelf buttons(apps), which draw their focus rectangle in a different place. See https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_button.cc?rcl=0&l=472 My intent is to tweak focus rectangle of trays because right now they all looks a little short(just like system tray).
,
Nov 18 2016
Changing the title of this bug because it also reproduces when logged in. When logged in you need to use ctrl+F1 (back arrow) in order to get the focus rect on the system tray and other tray items (VK button, opt-in IME button, notification center, etc).
,
Nov 19 2016
View the latest output: https://drive.google.com/drive/folders/0B36J1AuBzU4RZUFjMVJIZlQzZWc?usp=sharing
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc commit dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc Author: xiaoyinh <xiaoyinh@chromium.org> Date: Mon Nov 21 21:57:22 2016 tweak the focus rectangle of TrayBackgroundView objects BUG= 640678 TEST=Manually tested on lock screen and signin screen, also after signin. Review-Url: https://codereview.chromium.org/2513823002 Cr-Commit-Position: refs/heads/master@{#433662} [modify] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/ash/common/system/tray/actionable_view.h [modify] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/ash/common/system/tray/tray_background_view.h
,
Nov 21 2016
,
Nov 21 2016
I'll re-request the merge once this hits canary and I have verified it.
,
Nov 25 2016
Sorry, changed my mind from #15. Still waiting for this to make it to canary for verification but let's re-apply the label to get merge permission in the meanwhile.
,
Nov 25 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
Verified on 57.0.2933.0 canary. Performing the merge now.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd commit 12bb3fd38e5b5b815ddf8d586fe040c750fed2dd Author: Terry Anderson <tdanderson@chromium.org> Date: Mon Nov 28 19:15:05 2016 tweak the focus rectangle of TrayBackgroundView objects BUG= 640678 TEST=Manually tested on lock screen and signin screen, also after signin. Review-Url: https://codereview.chromium.org/2513823002 Cr-Commit-Position: refs/heads/master@{#433662} (cherry picked from commit dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc) Review URL: https://codereview.chromium.org/2533903002 . Cr-Commit-Position: refs/branch-heads/2924@{#118} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/actionable_view.h [modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/12bb3fd38e5b5b815ddf8d586fe040c750fed2dd/ash/common/system/tray/tray_background_view.h
,
Nov 28 2016
,
Nov 29 2016
Issue 661906 has been merged into this issue.
,
Dec 2 2016
Verified on ChromeOS 9000.15.0, 56.0.2924.12 |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by yiyix@chromium.org
, Aug 24 20164.1 KB
4.1 KB View Download