Get rid of SVGAnimateElement::findElementInstances |
||
Issue descriptionThis function has been a thorn in my eye for a while since it seems a bit backwards from a layering perspective. Instead we should define a simple interface on SVGElement to be able to achieve what this function does. This will also mean that the SMIL engine doesn't need to care about <use> and its consequences.
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3d278956414b3921db701fcd575e41841440ed7 commit d3d278956414b3921db701fcd575e41841440ed7 Author: fs <fs@opera.com> Date: Thu Aug 25 21:22:19 2016 Move animVal invalidation from SVGAnimateElement to SVGElement BUG= 640676 Review-Url: https://codereview.chromium.org/2281643003 Cr-Commit-Position: refs/heads/master@{#414543} [modify] https://crrev.com/d3d278956414b3921db701fcd575e41841440ed7/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp [modify] https://crrev.com/d3d278956414b3921db701fcd575e41841440ed7/third_party/WebKit/Source/core/svg/SVGElement.cpp [modify] https://crrev.com/d3d278956414b3921db701fcd575e41841440ed7/third_party/WebKit/Source/core/svg/SVGElement.h
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfa5adc96879fea39db27d190261e82ae3b85624 commit cfa5adc96879fea39db27d190261e82ae3b85624 Author: fs <fs@opera.com> Date: Fri Aug 26 21:20:39 2016 Fold SMIL animation value application helpers and simplify Folds the following helper functions: applyCSSPropertyToTargetAndInstances removeCSSPropertyFromTargetAndInstances notifyTargetAndInstancesAboutAnimValChange into their users, hoisting common predicates and simplifies accordingly. BUG= 640676 Review-Url: https://codereview.chromium.org/2285473002 Cr-Commit-Position: refs/heads/master@{#414808} [modify] https://crrev.com/cfa5adc96879fea39db27d190261e82ae3b85624/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf9460b9549540ba98ae846e12b2fa91133d62e commit abf9460b9549540ba98ae846e12b2fa91133d62e Author: fs <fs@opera.com> Date: Fri Aug 26 22:52:25 2016 Reduce 'iterate self and instances' helper-count in SVGElement.cpp Generalizing updateInstancesAnimatedAttribute{,NoInvalidate} to one higher-level helper to get rid of the subtle differences brought on by the differences in invalidation semantics. BUG= 640676 Review-Url: https://codereview.chromium.org/2280923002 Cr-Commit-Position: refs/heads/master@{#414845} [modify] https://crrev.com/abf9460b9549540ba98ae846e12b2fa91133d62e/third_party/WebKit/Source/core/svg/SVGElement.cpp
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a commit fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a Author: fs <fs@opera.com> Date: Tue Aug 30 09:20:45 2016 Tighten SVGAnimationElement::shouldApplyAnimation Fold the targetIsUsable(...) helper from SVGAnimateElement into said method, and then replace the uses of the former with the corresponding 'should apply' predicate. BUG= 640676 Review-Url: https://codereview.chromium.org/2287983002 Cr-Commit-Position: refs/heads/master@{#415253} [modify] https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp [modify] https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e7202542f73e6a411d0c1808e2112a150254e3b commit 2e7202542f73e6a411d0c1808e2112a150254e3b Author: fs <fs@opera.com> Date: Tue Aug 30 11:30:49 2016 Simplify SVGAnimatedTypeAnimator interface The two methods startAnimValAnimation and resetAnimValToBaseVal share the same implementation, but are called in two different branches of the same if-statement. Fold the two and add a new method createAnimatedValue() to provide the animated value, to make this appear as straight-forward as it is. Also fold the stopAnimValAnimation() method since it's only used once, and because this makes the start/stop action somewhat symmetric. Rename the constructFromString(...) method to createAnimatedValueFromString() to illustrate its relation to the newly minted method and make it a bit more clear what it does. BUG= 640676 Review-Url: https://codereview.chromium.org/2284263002 Cr-Commit-Position: refs/heads/master@{#415271} [modify] https://crrev.com/2e7202542f73e6a411d0c1808e2112a150254e3b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp [modify] https://crrev.com/2e7202542f73e6a411d0c1808e2112a150254e3b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp [modify] https://crrev.com/2e7202542f73e6a411d0c1808e2112a150254e3b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0d55affa1f3a57e3d8ec8c0911f56b2bbb54f27 commit c0d55affa1f3a57e3d8ec8c0911f56b2bbb54f27 Author: fs <fs@opera.com> Date: Tue Aug 30 19:26:26 2016 Don't add redundant references to animated target element SVGSMILElement adds a reference to its target, and any instances of the target should never be mutated, so the registration of reference to the extended target element set in SVGAnimateElement::resetAnimatedType does not add any value. BUG= 640676 Review-Url: https://codereview.chromium.org/2292983002 Cr-Commit-Position: refs/heads/master@{#415393} [modify] https://crrev.com/c0d55affa1f3a57e3d8ec8c0911f56b2bbb54f27/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1792ae27e0a2a97863e839532bbfe81117be21ac commit 1792ae27e0a2a97863e839532bbfe81117be21ac Author: fs <fs@opera.com> Date: Thu Sep 01 07:54:04 2016 Move SVGAnimateElement::findElementInstances to SVGElement.cpp There's now only a single user of this function, so fold the function into that one. BUG= 640676 Review-Url: https://codereview.chromium.org/2293173003 Cr-Commit-Position: refs/heads/master@{#415901} [modify] https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp [modify] https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac/third_party/WebKit/Source/core/svg/SVGAnimateElement.h [modify] https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac/third_party/WebKit/Source/core/svg/SVGElement.cpp
,
Sep 1 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 25 2016