Fix strings in download recovery dialogs |
|||||||
Issue descriptionDownload recovery dialog is the last chance chrome discourages users from landing dangerous files to their file system, thus the information presented here should be accurate and consistent with the download warning previously shown to users. However, some of the strings in this warning dialog have been mismatched or not accurate for a long time, e.g. https://crbug.com/607298 , https://crbug.com/415377 and etc. Detailed plan for fixing these issues can be found here: https://docs.google.com/document/d/1M9AvvXafVRSNquKGhzjAqo3Pl7sSATuEECA78pfkpmA/edit#
,
Aug 24 2016
Issue 415377 has been merged into this issue.
,
Aug 26 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f857966ed00a2e7703f98f901d28ae3677592341 commit f857966ed00a2e7703f98f901d28ae3677592341 Author: jialiul <jialiul@chromium.org> Date: Tue Sep 13 19:43:12 2016 Improve download recovery flow: (1) refine strings in download recovery dialog (2) remove all message leads, and keep title and message body to simply previously lengthy text in download recovery dialog (3) refine description strings that used to explain the reason why download is blocked in chrome://downloads (text in orange) (4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user try to recover a blocked download, directly proceed instead of showing download danger prompt. go/fix_download_recovery for more detail BUG= 640673 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2314903003 Cr-Commit-Position: refs/heads/master@{#418340} [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/app/chromium_strings.grd [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/app/generated_resources.grd [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/download/download_danger_prompt.h [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/views/download/download_danger_prompt_views.cc [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc [modify] https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
,
Sep 13 2016
,
Sep 15 2016
To confirm, which Chrome version did this fix go into?
,
Sep 15 2016
according to git find-releases, it will be in 55.0.2860.0. So M55.
,
Sep 30 2016
,
Sep 30 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jialiul@chromium.org
, Aug 24 2016