New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640669 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: ----

Blocking:
issue 640728



Sign in to add a comment

chrome_sync_shell_test_apk on Android failing on chromium.linux/Android Tests

Project Member Reported by hanxi@chromium.org, Aug 24 2016

Issue description

chrome_sync_shell_test_apk (org.chromium.chrome.browser.sync.BookmarksTest_testDownloadMovedBookmark) on Android failing on chromium.linux/Android Tests

Type: build-failure

Builders failed on: 
- Android Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

Reasons:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30991/steps/chrome_sync_shell_test_apk%20on%20Android

The suspicious CL is:
https://codereview.chromium.org/2276013002


 

Comment 1 by aiolos@chromium.org, Aug 24 2016

This is blocking the catapult autoroller.

Comment 2 by hanxi@chromium.org, Aug 24 2016

I will try to repro the failure locally.

Comment 3 by hanxi@chromium.org, Aug 24 2016

Cc: treib@chromium.org nednguyen@chromium.org rogerm@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I can't reproduce it locally.
+rogerm@ and +neduguyen to help triage.
Cc: jbudorick@chromium.org
Attempting to repo as well. I agree that the NTP change is the most likely suspect.
If we can't repro and revert quickly, though, we ought to disable the test to unblock the CQ.

Comment 7 by hanxi@chromium.org, Aug 24 2016

I will prepare a CL to disable the test.
sgtm

Comment 9 by hanxi@chromium.org, Aug 24 2016

CL is created to disable the test: https://codereview.chromium.org/2271333002/.
I saw some flakiness on this test in my try runs (setting up find experiment config testing).

I'm don't think my experiment (enabling deduplication of autofill profiles) should be interacting with Bookmarks at all. But there was definitely some flakiness in my trybot runs (not only for this Android test).

See https://codereview.chromium.org/2268753002 and expand the trybot results.

  - linux_android_rel_ng
  - max_chromium_rel_ng
  - win_chromium_rel_ng



O_O
https://codereview.chromium.org/2276013002 exhibited no such flakes in its try runs, so I'd say we have a new suspected CL.

Comment 13 by hanxi@chromium.org, Aug 24 2016

A revert is created in in CQ. Thanks for the investigation. I should expand the trybots and see the previous results.

Comment 14 by hanxi@chromium.org, Aug 24 2016

The revert (https://codereview.chromium.org/2276103003/) is landed, hopefully these bots will turn green.
I'm able to reproduce this locally, but only on the second and subsequent run of the test after APK installation -- the first run always seems to pass.

I build to match chromium.linux:Android Builder via

  ./tools/mb/mb.py gen -m chromium.linux -b "Android Builder" <output directory>
  ninja -C <output directory> [options] chrome_sync_shell_test_apk

and used an N5 on KTU84P, the same as Android Tests and linux_android_rel_ng.

Comment 16 by hanxi@chromium.org, Aug 24 2016

Thanks for sharing, I can reproduce it locally too. Yes, need to run the test twice to get the failure.
Blocking: 640728
Looks like the revert was successful.

31001 and later builds are green:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/31001

Comment 19 by hanxi@chromium.org, Aug 24 2016

Awesome!
Owner: hanxi@chromium.org
Status: Fixed (was: Untriaged)
Thanks for fixing this, hanxi!
Cc: hanxi@chromium.org maxbogue@chromium.org
 Issue 640728  has been merged into this issue.
The order of the folder and bookmark is the reverse of that expected for
the 2nd and subsequent runs.

Swapping the 0 and 1 indices causes the tests to pass, but I haven't yet
tracked down why this is happening in the first place.
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778c94f05935d22b8e0555616d0faaf277ad5b7a

commit 778c94f05935d22b8e0555616d0faaf277ad5b7a
Author: rogerm <rogerm@chromium.org>
Date: Tue Aug 30 21:21:38 2016

Fix BookmarksTest#testDownloadMovedBookmark to be insensitive to item order.

BUG=620414,  640669 ,  64218 

Review-Url: https://codereview.chromium.org/2289803002
Cr-Commit-Position: refs/heads/master@{#415430}

[modify] https://crrev.com/778c94f05935d22b8e0555616d0faaf277ad5b7a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

Sign in to add a comment