New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640659 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[all boards] Audio input is broken

Project Member Reported by ka...@chromium.org, Aug 24 2016

Issue description

Tests broken - issue 640651 and issue 640653

Tested Celes and Link on R54-8737.0.0

Audio jack and USB audio input is broken. There is no audio produced from microphone.

Generated logs will be attached to this bug.
 

Comment 2 by ka...@chromium.org, Aug 24 2016

audio Microphone test is passing at R54-8733.0.0, but failing at R54-8734.0.0
https://screenshot.googleplex.com/W9HhsgbQbMt


log of link device: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cros/640659/?debugUI=CLOUD

observed /var/log/messages error out : 
chronos@localhost / $ tail -f /var/log/messages
2016-08-24T17:10:25.753436+00:00 ERR cras_server[3645]: pcm_avail returned frames larger than buf_size: 22105776 > 16384

Labels: -Type-Bug M-54 Type-Bug-Regression

Comment 5 by ka...@chromium.org, Aug 24 2016

This Error log (pcm_avail) is flooding the messages logs - https://chromium-review.googlesource.com/#/c/371118/

Comment 6 by dgreid@chromium.org, Aug 24 2016

Owner: cychiang@chromium.org

Comment 7 by ka...@chromium.org, Aug 24 2016

Cc: rjahagir@chromium.org
Reproduce the issue on CrOS 8737.0.0/54.0.2837.0 - Candy. 

Comment 9 by ka...@chromium.org, Aug 24 2016

Summary: [all boards] Audio input is broken (was: Audio input is broken)
Status: Assigned (was: Untriaged)
Sounds like a dup of  issue  640048 

Comment 12 by ka...@chromium.org, Aug 24 2016

Nope.  Issue 640048  is audio output issue on chell only.
Status: Started (was: Assigned)
I think this is caused by iodev refactoring change.
I will check and revert it.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 25 2016

Labels: merge-merged-stabilize-8737.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/f70e99042ea6ed37127def9e98afa9758f870e3d

commit f70e99042ea6ed37127def9e98afa9758f870e3d
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Aug 25 03:05:03 2016

Revert "CRAS: iodev - Move no stream state transition into cras_iodev"

This reverts commit 2a98fae9e8eb798f7a16481a578594b787b93ff7.

The change somehow broke recording path. Revert it now and
investigate it later.

BUG= chromium:640659 , chromium:519942 
TEST=check recording works fine on chell.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Change-Id: Id8b0aa175b4cf1388889a7d7f00e9eb6c5243df8
Reviewed-on: https://chromium-review.googlesource.com/375698

[modify] https://crrev.com/f70e99042ea6ed37127def9e98afa9758f870e3d/cras/src/server/cras_iodev.h
[modify] https://crrev.com/f70e99042ea6ed37127def9e98afa9758f870e3d/cras/src/tests/iodev_unittest.cc
[modify] https://crrev.com/f70e99042ea6ed37127def9e98afa9758f870e3d/cras/src/server/audio_thread.c
[modify] https://crrev.com/f70e99042ea6ed37127def9e98afa9758f870e3d/cras/src/tests/audio_thread_unittest.cc
[modify] https://crrev.com/f70e99042ea6ed37127def9e98afa9758f870e3d/cras/src/server/cras_iodev.c

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7

commit d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Aug 25 03:05:16 2016

Revert "CRAS: iodev - Add state variable in cras_iodev"

This reverts commit e9e2c8e19fa28a469372bfa3e5fd942dcbb26f90.

The change somehow broke recording path. Revert it now and investigate
it later.

BUG= chromium:640659 , chromium:519942 
TEST=check recording works fine on chell.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Change-Id: I2f6b17fd158f4063c69154810a14ed1b4e74e1b9
Reviewed-on: https://chromium-review.googlesource.com/375699

[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_a2dp_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_iodev_list.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/iodev_list_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_hfp_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/hfp_iodev_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_bt_device.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/loopback_iodev_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_empty_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_iodev.h
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/iodev_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_loopback_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/audio_thread.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/audio_thread_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/alsa_io_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/bt_device_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/test_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_iodev.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/tests/bt_io_unittest.cc
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_alsa_io.c
[modify] https://crrev.com/d64e3f69de2bc7f96418d32c43ae7d3d1a6b4af7/cras/src/server/cras_bt_io.c

These two CL on ToT are waiting to be merged
https://chromium-review.googlesource.com/#/c/375658/
https://chromium-review.googlesource.com/#/c/375659/1

I am investigating the root cause.
Sorry for the trouble.
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/8ebc96cf4135d449b8473e191386e0f896372039

commit 8ebc96cf4135d449b8473e191386e0f896372039
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Aug 25 03:05:16 2016

Revert "CRAS: iodev - Add state variable in cras_iodev"

This reverts commit e9e2c8e19fa28a469372bfa3e5fd942dcbb26f90.

The change somehow broke recording path. Revert it now and investigate
it later.

BUG= chromium:640659 , chromium:519942 
TEST=check recording works fine on chell.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Change-Id: I2f6b17fd158f4063c69154810a14ed1b4e74e1b9
Reviewed-on: https://chromium-review.googlesource.com/375659

[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_a2dp_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_iodev_list.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/iodev_list_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_hfp_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/hfp_iodev_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_bt_device.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/loopback_iodev_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_empty_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_iodev.h
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/iodev_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_loopback_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/audio_thread.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/audio_thread_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/alsa_io_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/bt_device_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/test_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_iodev.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/tests/bt_io_unittest.cc
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_alsa_io.c
[modify] https://crrev.com/8ebc96cf4135d449b8473e191386e0f896372039/cras/src/server/cras_bt_io.c

Status: Fixed (was: Started)
This is fixed as the two revert CLs were merged.
Waiting for next build test result to mark verified.

Comment 20 by ka...@chromium.org, Aug 25 2016

Status: Verified (was: Fixed)
Thanks Jimmy - R54-8740.0.0 build is passing audio_Microphone test.
https://wmatrix.googleplex.com/unfiltered?tests=audio_Microphone
Will confirm with chameleon tests too.

Sign in to add a comment