As of r411324, overflow button has a circular background as it shares its background image with the launcher button. I think this is not intended; it should have a rectangular background.
+kuscher@ as FYI. I assume a circular overflow button is RBS for M-53?
My fault... caused by https://codereview.chromium.org/2234103002. Please stand by...
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc77d07303f42212610e01d7fac2e8e4dd01647a commit cc77d07303f42212610e01d7fac2e8e4dd01647a Author: glevin <glevin@chromium.org> Date: Thu Aug 25 19:09:47 2016 Fix background of overflow shelf icon BUG= 640642 TEST=Add shelf icons and/or increase zoom until shelf overflows. Observe that background of overflow button is square, not round. Review-Url: https://codereview.chromium.org/2277523004 Cr-Commit-Position: refs/heads/master@{#414501} [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/common/shelf/app_list_button.cc [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/ash_resources.grd [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_icon_background_normal.png [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_icon_background_pressed.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_normal.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_pressed.png [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_icon_background_normal.png [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png [modify] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_icon_background_pressed.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_normal.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png [add] https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_pressed.png
glevin@ can you please request merge to M53 and merge by tomorrow so we can bake it for a day or two before we cut a new beta next week.
[Automated comment] GRD changes detected, less than 3 weeks to before stable release of M53, manual review required.
Approving merge to M53 cros.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/805f2f810a2ab4bf8380b61571d79c7788c5044c commit 805f2f810a2ab4bf8380b61571d79c7788c5044c Author: glevin <glevin@chromium.org> Date: Fri Aug 26 21:59:43 2016 Fix background of overflow shelf icon BUG= 640642 TEST=Add shelf icons and/or increase zoom until shelf overflows. Observe that background of overflow button is square, not round. Review-Url: https://codereview.chromium.org/2277523004 Cr-Commit-Position: refs/heads/master@{#414501} (cherry picked from commit cc77d07303f42212610e01d7fac2e8e4dd01647a) Review URL: https://codereview.chromium.org/2287753002 . Cr-Commit-Position: refs/branch-heads/2785@{#767} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/ash_resources.grd [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_icon_background_normal.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_icon_background_pressed.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_normal.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_pressed.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_icon_background_normal.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_icon_background_pressed.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_normal.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png [add] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_pressed.png [modify] https://crrev.com/805f2f810a2ab4bf8380b61571d79c7788c5044c/ash/shelf/app_list_button.cc
Comment 1 by tdander...@chromium.org
, Aug 24 2016Labels: ReleaseBlock-Stable