New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640623 link

Starred by 1 user
Status: Fixed
Owner:
█ bzanotti@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 634267



Sign in to add a comment

Make FakeChromeIdentityService ready to be used in integration tests.

Project Member Reported by bzanotti@chromium.org, Aug 24 2016 
FakeChromeIdentityService is currently used in unit tests. We also want to use it in integration tests instead of the current solution (which mocks the internal of our shared login library and can't be upstreamed).

There is two changes necessary:
* Upstreamable code should always use method existing in ChromeIdentityService instead of its downstream implementation. This means upstreaming new methods in ChromeIdentityService.
* Allow FakeChromeIdentityService to be used with the real ChromeBrowserProvider. The TestChromeBrowserProvider is useful for unit tests but fakes too many services for integration tests. This means the ChromeBrowserProvider should always own its ChromeIdentityService, and also allow it to be overridden.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be21c8594be847e6520d41b4384b0fcd90e88c51

commit be21c8594be847e6520d41b4384b0fcd90e88c51
Author: bzanotti <bzanotti@chromium.org>
Date: Mon Aug 29 15:14:55 2016

Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

The ChromeBrowserProvider implementations should now also own their
ChromeIdentityService and allow it to be overriden. This is necessary
so that FakeChromeIdentityService can be used with the real
ChromeBrowserProvider in integration tests.

Also upstream some methods in ChromeIdentityService.

BUG= 640623 

Review-Url: https://codereview.chromium.org/2274163002
Cr-Commit-Position: refs/heads/master@{#415011}

[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/chrome_browser_provider.h
[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/chrome_browser_provider.mm
[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/signin/chrome_identity_service.h
[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm
[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/test_chrome_browser_provider.h
[modify] https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/68abe9dd88227f36a795ba1ebe037dcd6f7360a4

commit 68abe9dd88227f36a795ba1ebe037dcd6f7360a4
Author: bzanotti <bzanotti@google.com>
Date: Mon Aug 29 18:16:47 2016

Comment 4 by bzanotti@chromium.org, Aug 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment