We do have public bots running cronet_unittests on Android.

@mgersh could you point me to the bots?  I couldn't find one that ran cronet_unittests when I looked under the "android" column.

If this is covered by bots, why didn't the CQ catch this?  Should that be fixed?

All of the Cronet Android bots: https://build.chromium.org/p/chromium.android/waterfall?builder=Android+Cronet+ARM64+Builder&builder=Android+Cronet+ARM64+Builder+%28dbg%29&builder=Android+Cronet+ARMv6+Builder&builder=Android+Cronet+Builder+%28dbg%29&builder=Android+Cronet+Builder+Asan&builder=Android+Cronet+Data+Reduction+Proxy+Builder&builder=Android+Cronet+KitKat+Builder&builder=Android+Cronet+Lollipop+Builder&builder=Android+Cronet+MIPS+Builder&builder=Android+Cronet+Marshmallow+64bit+Builder&builder=Android+Cronet+Marshmallow+64bit+Perf&builder=Android+Cronet+x86+Builder&builder=Android+Cronet+x86+Builder+%28dbg%29&reload=none

About half of those run the tests, including cronet_unittests, the other half just compile them. None of them are currently on the CQ, although we'd like them to be, see  issue 634350 .

If you're talking about https://codereview.chromium.org/1898873006, that one did cause a failure on our asan builder ( issue 640635 ). Looks like all the failing bots use clang, and the passing ones use gcc (default for android).

Thanks for the pointers!  It sounds like we've got decent coverage on the Android side.

For iOS, I'd like to either add this test suite to the main waterfall or remove it from the internal builders, so that we reduce the possibility of future submarine failures.

@cronet folks, are these tests stable enough to be on the main waterfall?  Would you object if we removed them from the internal builders instead?

TBH I was unaware that internal iOS builders run any of those, and I'll be fine with excluding them from internal builders.

Sana, could you take a look at it? We would like to add extra tests for iOS platform.

My understanding was that cronet_unittests require different gn_args to build. We have an experimental try bot (not part of the CQ) that runs them:
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-simulator-cronet

And it sets extra gn_args:
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/chromium.mac/ios-simulator-cronet.json

Can you get cronet_unittests compiling without these? Then we could run them on the CQ without having to add additional VM capacity. If so, just add them here and trigger a try job on ios-simulator:
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/chromium.mac/ios-simulator.json

If it's green you can send out the CL to add cronet_unittests to all the bots.

Alternately we could set all the extra gn_args on ios-simulator, but I don't know what impact that has on the Chromium build.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/639579130d04f71ab1678e4a5da6e2aa488b7672

commit 639579130d04f71ab1678e4a5da6e2aa488b7672
Author: Misha Efimov <mef@chromium.org>
Date: Wed Dec 06 07:13:26 2017

[Cronet] Run cronet_unittests on iOS bots.

Bug:  640621 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33516d4a22a9f2da017749f1cf9eb8cd04314725
Reviewed-on: https://chromium-review.googlesource.com/809192
Reviewed-by: smut <smut@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522034}
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/ios/build/bots/chromium.fyi/ios-simulator-cronet.json
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/ios/build/bots/chromium.mac/ios-simulator-cronet.json
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/639579130d04f71ab1678e4a5da6e2aa488b7672/testing/buildbot/manage.py