New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Clank downstream clang-builder failed to compile.

Project Member Reported by hanxi@chromium.org, Aug 24 2016

Issue description

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/clang-builder/builds/6983

The compile error is:
../../components/cronet/stale_host_resolver_unittest.cc:61:3: error: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
  ~MockHostResolverProc() override {}
  ^
../../components/cronet/stale_host_resolver_unittest.cc:57:30: note: [chromium-style] 'MockHostResolverProc' inherits from 'net::HostResolverProc' here
class MockHostResolverProc : public net::HostResolverProc {
                             ^
../../net/dns/host_resolver_proc.h:27:7: note: [chromium-style] 'HostResolverProc' inherits from 'base::RefCountedThreadSafe<HostResolverProc>' here
    : public base::RefCountedThreadSafe<HostResolverProc> {
      ^
../../components/cronet/stale_host_resolver_unittest.cc:81:28: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  ~StaleHostResolverTest() {}
                           ^
                            override

The CL (https://codereview.chromium.org/1898873006/) causes the compile issue.

A CL has been committed by bauerb@ to fix one of the error:
https://codereview.chromium.org/2277453003/

juliatuttle@ is looking for a fix for the remaining one.

File this bug to track the progress.


 

Comment 1 by bauerb@chromium.org, Aug 24 2016

Oh, I overlooked that there was a second class! Sorry about that :-(

Comment 2 by hanxi@chromium.org, Aug 24 2016

Cc: agrieve@chromium.org
The other fix should be in CQ soon: https://codereview.chromium.org/2274123002/.
Thank you bauerb@ for committing the first CL:)

+agrieve@ who is looking for why our upstream bots didn't catch up the compile error.
I've filed  Issue 640621  to make sure the bots run cronet_unittests.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8ffed2cce5a4564ba11af36982a9bc8e5710f93

commit a8ffed2cce5a4564ba11af36982a9bc8e5710f93
Author: juliatuttle <juliatuttle@chromium.org>
Date: Wed Aug 24 17:56:03 2016

Make ~StaleHostResolverTest override.

BUG= 640618 
TBR=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2274123002
Cr-Commit-Position: refs/heads/master@{#414101}

[modify] https://crrev.com/a8ffed2cce5a4564ba11af36982a9bc8e5710f93/components/cronet/stale_host_resolver_unittest.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Sep 8 2016

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Verified fixed.

Sign in to add a comment