New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640604 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Oct 2016
Cc:
█ melodychu@chromium.org
hwi@chromium.org
abodenha@chromium.org
█ kuscher@chromium.org
█ ainslie@chromium.org
afakhry@chromium.org
█ rolfe@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Feedback] Update strings.

Project Member Reported by apaci...@chromium.org, Aug 24 2016 
Update the current feedback form:
- Omit the period in the title
- Omit colons from labels, for example, in the labels for fields in a form.  (MD spec)
- Shorten button label
- Shorten the string for attached file being sent to google
- "(optional)" indicator can either be omitted altogether or we can add a grouping label e.g. "Additional info (optional)", "Please send related information to help us debug (optional)"

See screenshot.

note to self: This should also be reflected for MD Feedback.
image.jpg
345 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864

commit 35eabf5bbca04507bfe6ae32b6f9e9d5cc251864
Author: apacible <apacible@chromium.org>
Date: Wed Aug 31 17:14:28 2016

[Feedback] Update strings per UX recommendations.

Changes include:
- Omitting trailing period and colons from labels/headers.
- Omitting "optional" text from labels and adding group subheading to indicate optional fields.
- Shorten some strings.

Used camelCase for new string per presubmit guidelines for i18n-content.

BUG= 640604 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2293673002
Cr-Commit-Position: refs/heads/master@{#415666}

[modify] https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864/chrome/app/generated_resources.grd
[modify] https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864/chrome/browser/resources/feedback/css/feedback.css
[modify] https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864/chrome/browser/resources/feedback/html/default.html

Comment 2 by afakhry@chromium.org, Sep 20 2016 

apacible, this should be Fixed, right?
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85cfd05f49f4504cf5014cd1beb18841192b9328

commit 85cfd05f49f4504cf5014cd1beb18841192b9328
Author: apacible <apacible@chromium.org>
Date: Mon Oct 03 18:49:45 2016

[MD Feedback] Add initial styling to feedback dialog.

Small tweaks to current dialog, including text sizing and positioning.

BUG= 640604 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2309683002
Cr-Commit-Position: refs/heads/master@{#422472}

[modify] https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328/chrome/app/generated_resources.grd
[modify] https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328/chrome/browser/resources/md_feedback/feedback_container.html
[modify] https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc

Comment 4 by apaci...@chromium.org, Oct 3 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment