"https" in incognito omnibox should be white when secure, grey otherwise
Reported by
geki...@gmail.com,
Aug 24 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2837.0 Safari/537.36 Steps to reproduce the problem: 1. open incognito window (Material Design enabled) 2. open https page 3. What is the expected behavior? i think "https" should grey to make a better readable url you do it already on android chrome beta What went wrong? https is "white" like the hostname of the url Did this work before? N/A Chrome version: 54.0.2837.0 Channel: dev OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0 not a real bug :)
,
Sep 1 2016
,
Sep 1 2016
Hmmmm. We're kinda trying to call out the scheme when it's HTTPS. That's why it's green and not grey in non-incognito. We made a decision (which I didn't like but whatever) to use monochromatic white icons and security text in incognito mode. Since the scheme color matches those colors in normal, it should match in incognito too. So I submit that Android should change to match desktop instead of the other way around. Morphing.
,
Sep 1 2016
,
Sep 14 2016
I agree with pkasting: we should call out the scheme when it's HTTPS. This also helps to clarify the difference to cases liked mixed content (no lock icon, dimmed scheme). We moved away from using red/green on a dark background since it's unacceptable from an accessibility perspective (color contrast ratio of red scheme in incognito mode: 1.1!). I attached on overview of the different cases.
,
Sep 14 2016
Does this look good to you, pkasting?
,
Sep 14 2016
Well, note that on that grey background, we'd want to use a lighter red if we wanted a colored scheme. GetReadableColor() would have done that automatically :). So yeah, the contrast of that particular combo is terrible, but that alone wouldn't rule out colored schemes. However, if we already decided not to use colored icons (of any color), colored schemes don't make sense either. I still want Android to use the much-more-visible diagonal strikethrough we use on desktop rather than the horizontal -- it's much more visible. But in terms of when to dim and not dim things, I agree with comment 5. Note that Windows is not currently correct here; https://mozilla-old.badssl.com/ correctly dims the scheme in incognito, but pages that strikethrough the scheme like https://expired.badssl.com/ show it as white. I did not check Mac.
,
Dec 8 2016
Forgive me if this new label is inappropriate.
,
Dec 8 2016
Yep, that's the right component.
,
Apr 28 2017
Issue 715710 has been merged into this issue.
,
Apr 28 2017
Issue 715710 is a different issue. Please unlink them (I can't find how with my user level).
,
Apr 28 2017
> Issue 715710 is a different issue. > Please unlink them (I can't find how with my user level). Done.
,
Nov 10 2017
,
Feb 18 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ranjitkan@chromium.org
, Aug 25 2016Components: -UI
Labels: -Type-Bug Proj-MaterialDesign-WebUI Type-Feature