New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640526 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.6% regression in speedometer at 413780:413803

Project Member Reported by nikolaos@chromium.org, Aug 24 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=640526

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvtDPsAoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 24 2016

Cc: lukasza@chromium.org
Owner: lukasza@chromium.org

=== Auto-CCing suspected CL author lukasza@chromium.org ===

Hi lukasza@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Skip virtual equivalent of async-callstack-async-await*.html layout tests.
Author  : lukasza
Commit description:
  
Non-virtual async-callstack-async-await*.html tests have been disabled
in r409884, but the tests have been flakily running and timing out in
the virtual test suites:

- Site Isolation Win:
  https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15853

- WebKit Mac10.11 (dbg):
  https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fasyncawait%2Finspector%2Fsources%2Fdebugger-async%2Fasync-await%2Fasync-callstack-async-await2.html

Based, on the above, this CL is broadening the test expectations for
virtual/asyncawait/.../async-callstack-async-await[23].html so that:

- They cover non-Debug builds (since Site Isolation Win tests Release build)

- They cover all platforms (since these tests are also flaky on Mac10.11)

BUG= 636835 ,  621515 
NOTRY=true

Review-Url: https://codereview.chromium.org/2276583002
Cr-Commit-Position: refs/heads/master@{#413786}
Commit  : c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339
Date    : Tue Aug 23 18:14:56 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@413779  883.253  13.6524  12  good
chromium@413785  892.035  17.136   18  good
chromium@413786  874.604  16.358   18  bad    <--
chromium@413787  874.819  13.0233  18  bad
chromium@413788  873.82   18.6838  18  bad
chromium@413791  875.933  17.7742  18  bad
chromium@413803  866.169  13.3108  8   bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 640526

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: React-TodoMVC/React-TodoMVC
Relative Change: 2.15%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2327
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003455126656972496


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5838127701164032

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: -lukasza@chromium.org
Owner: nikolaos@chromium.org
nikolaos@, the change in #c3 is changing only test expectations (so - it doesn't change product code or test code).  Therefore, the change from #c3 cannot possibly be responsible for the regression.
Status: WontFix (was: Assigned)
This seems to be a flake, I'm closing it as a WontFix.

Sign in to add a comment