New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640525 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Quick View: FOUC (wrong size image) is seen on opening a large image in Quick View.

Project Member Reported by oka@chromium.org, Aug 24 2016

Issue description

Version: ToT

What steps will reproduce the problem?
(1) Select a large image (e.g. huge.jpg attached) on Files App and push Space key, and observe.

What is the expected output?
- Image should be shown in center of the window without any flush of unstyled content.

What do you see instead?
- Sometimes a small image (100 x 100) is seen on upper left corner first, and then it expands to the expected size. See the attached screencast (webview_img_fouc.webm).


Note that the image is rendered inside a <webview> tag for security reasons.
 
webview_img_fouc.webm
518 KB View Download
huge.jpg
6.4 MB View Download

Comment 1 by oka@chromium.org, Aug 24 2016

The red and blue border in the attached image is just to clarify element sizes in html.
Red: <webview> tag
Blue: inner html's <html> tag

Comment 2 by oka@chromium.org, Aug 24 2016

Summary: Quick View: FOUC (wrong size image) is seen on opening a large image in Quick View. (was: Quick View: FOUC (wrong size image) is seen on opening a large image with Quick View.)

Comment 3 by oka@chromium.org, Aug 25 2016

Looks like webview shows immature view before the inner window size fits into the <webview>'s window size.

I created a minimum chrome app which reproduces the issue. (repro.zip).
See the attached screencast (webview_bug.webm).

The FOUC only happens when webview is initially hidden.
repro.zip
5.2 MB Download
webview.webm
171 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/727463ca1bf5bba84683ab7f15bcfd101a5c46ef

commit 727463ca1bf5bba84683ab7f15bcfd101a5c46ef
Author: oka <oka@chromium.org>
Date: Fri Aug 26 03:26:53 2016

Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG= 640525 
TEST=manually tested by opening Quick View for audio, video and image files which were/weren't producing the FOUC issue before.

Review-Url: https://codereview.chromium.org/2274713006
Cr-Commit-Position: refs/heads/master@{#414645}

[modify] https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef/ui/file_manager/file_manager/foreground/elements/files_safe_audio_webview_content.html
[delete] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/file_manager/file_manager/foreground/elements/files_safe_audio_webview_content.js
[modify] https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.html
[delete] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.js
[add] https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef/ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js
[modify] https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html
[delete] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.js
[modify] https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef/ui/file_manager/file_manager_resources.grd

Comment 5 by oka@chromium.org, Aug 29 2016

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.6.0 / 55.0.2883.7

Sign in to add a comment