Regression:Navigation issue is observed on Md-settings.
Reported by
dmascare...@etouch.net,
Aug 24 2016
|
||||
Issue descriptionVersion:54.0.2838.0 (Official Build) 2ef45ff9caf531d43a366186a7c80d7307d91252-refs/heads/master@{#413929} 32/64 bit. OS: Windows(7,8,10), Mac(10.11.4,10.10.5),Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/ 2. Click on 'Side nav menu',click on 'Advanced' and then click on 'Reset' 3. Scroll up the page and then click on avatar icon ,click on back navigation arrow. 4. Observe. Actual:Unnecessary page navigate to 'Reset' section after step 3. Expected:'People' section should be seen. This is regression issue, broken in 'M 54' and will soon update the bisect: Good build:54.0.2831.0 Bad build:54.0.2832.0
,
Aug 24 2016
Hey michaelpg, dbeam: Should we prevent scrolling when we navigate back to a Section route via popstate? It leads to odd behavior like in this video currently.
,
Aug 24 2016
likely, yes
,
Aug 25 2016
yeah, this is something we've never formalized. I think "back to previous scroll position" is more likely to be helpful, and expected, than "back to top of previous route's section" when closing a section. I can't think of an example where the current behavior is better when closing a section. Good news is my collapse animation patch finally landed, so we should be able to scroll wherever we please without completely tearing the ~fabric~ quantum paper of the app.
,
Aug 25 2016
dbeam/michaelpg: I talked to Dave about this. IMO cleanest solution is just: Abolish section routes. All subpages become direct children of BASIC and ADVANCED. The side menu will have some other mechanism to scroll to the sections. Benefits: 1. No new URL that we would have to support forever. 2. Back navigations won't have any more counter-intuitive scroll behaviors. 3. 640480 will probably be fixed as a side effect of this. Cons: 1. Side menu scroll will have to be refactored a bit.
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/776eb73066021f12a815c669c73c4db433751d15 commit 776eb73066021f12a815c669c73c4db433751d15 Author: tommycli <tommycli@chromium.org> Date: Fri Sep 02 23:34:06 2016 MD Settings: Prevent unexpected scrolling to section on popstates. On subpage-backs or Browser back buttons, prevent the MainPageBehavior from scrolling to the position of the last routes' section. This makes section routes behave more like #anchorLinks. BUG= 640523 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2297663008 Cr-Commit-Position: refs/heads/master@{#416386} [modify] https://crrev.com/776eb73066021f12a815c669c73c4db433751d15/chrome/browser/resources/settings/route.js [modify] https://crrev.com/776eb73066021f12a815c669c73c4db433751d15/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/776eb73066021f12a815c669c73c4db433751d15/chrome/test/data/webui/settings/route_tests.js
,
Sep 2 2016
prolly fixed now |
||||
►
Sign in to add a comment |
||||
Comment 1 by dmascare...@etouch.net
, Aug 24 2016Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)