New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640511 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

EV SSL sign is shown as blank

Reported by pal...@gmail.com, Aug 24 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.70 Safari/537.36

Steps to reproduce the problem:
Today I just upgrade my browser and found the EV sign(for example, 'Twitter, Inc. [US]' ) turn to whole white. 

What is the expected behavior?
In address bar, before 'https://twitter.com' there should be a clickable 'Twitter, Inc. [US]'  button

What went wrong?
In address bar, before 'https://twitter.com' there is a long blank white button, also clickable

Did this work before? N/A 

Chrome version: 54.0.2837.0  Channel: dev
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by pal...@gmail.com, Aug 24 2016

I've downgrade my browser to chrome beta(and found the problem gone), so the User agent is not same as the time I found the problem.
When in dev channel, I've tested open twitter.com in incognito mode(and disabled all extensions in this mode), the problem is still there, so seems the bug is in browser itself.

Comment 2 by meh...@chromium.org, Aug 24 2016

Cc: spqc...@chromium.org shrike@chromium.org
Can you please post a screenshot of the bug? Thanks.
It's possible that the font color is incorrect. Are you able to replicate it on incognito or normal?
Labels: Needs-Feedback
Can't reproduce on Chrome 54.0.2837.0. See attached screenshot. Can you post a screenshot?
Screen Shot 2016-08-25 at 11.32.15 AM.png
12.6 KB View Download
Also, can you reproduce this on Chrome stable?

Comment 6 by pal...@gmail.com, Aug 25 2016

screenshot: https://i.imgur.com/Lo48Mj5.png
Found the reproduce method: 
1, chrome 54.0.2837 + (currently dev/canary)
2,install this theme: https://chrome.google.com/webstore/detail/aero-trans-brushed-metal/jkjdfchjlhkgnfjblhclgaliiccalckf?hl=zh-CN
3, open any EV SSL site like twitter or github, the EV sign is all blank, either normal or incognito.

Comment 7 by pal...@gmail.com, Aug 25 2016

Cannot reproduce in stable and beta, with same theme. 
Components: -UI UI>Browser>Omnibox
Labels: -Type-Bug -Needs-Feedback Needs-Bisect Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Verified the instructions in comment 6 and 7. Since this is not reproducible in beta, marking it as a regression. 
Status: WontFix (was: Untriaged)
This is how things are supposed to look.  We changed the appearance, we have not (yet) changed any functionality.
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
Status: Assigned (was: WontFix)
Wait a minute, I looked at the screenshot on comment 4, not comment 6.

I don't know why the EV text color would change with a theme installation.  It doesn't on views.
I'm pretty sure the reason why this is happening is because the EV cert thinks the dark theme = incognito. This should be a quick fix
Cc: ranjitkan@chromium.org
Labels: -Needs-Bisect M-54 ReleaseBlock-Beta
Able to reproduce the issue and issue is a regression broken in M54 only for MAC OS. Below are bisect Details for the same:

Bisect info:
============
54.0.2829.0 - Good Build
54.0.2830.0 - Bad Build

Bisect URL: 
===========
https://chromium.googlesource.com/chromium/src/+log/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6..6546cb056dbfca5975de3fd7dd29015b025f0cf6

Suspecting change #411994, could be the possible culprit.@ spqchan: Assigning to you, request you to please take a look into it. Please help us to reassign if not with respect to your change.

Change URL: https://chromium.googlesource.com/chromium/src/+/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72
Review-Url: https://codereview.chromium.org/2241943002

Thanks.!

Comment 13 by sh...@chromium.org, Aug 25 2016

 Issue 640785  has been merged into this issue.
Cc: spqc...@chromium.org f...@chromium.org
 Issue 641557  has been merged into this issue.
Status: Started (was: Assigned)
Fix in review:
Labels: Merge-Request-54

Comment 19 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5fed01d5c079bc81e640026b7320b602a8c587

commit 6a5fed01d5c079bc81e640026b7320b602a8c587
Author: spqchan <spqchan@chromium.org>
Date: Wed Aug 31 21:56:49 2016

[Material][Mac] Fix for bubble decoration text in dark theme

BUG= 640511 

Review-Url: https://codereview.chromium.org/2265423007
Cr-Commit-Position: refs/heads/master@{#415062}
(cherry picked from commit 9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd)

Review URL: https://codereview.chromium.org/2302603002 .

Cr-Commit-Position: refs/branch-heads/2840@{#83}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Status: Fixed (was: Started)
Labels: TE-Verified-54.0.2840.8 TE-Verified-M54
Rechecked this on chrome version 54.0.2840.8 on MAC 10.11.6. Fix is working as intended. Followed the below steps:

Installed chrome and Installed the theme "https://chrome.google.com/webstore/detail/aero-trans-brushed-metal/jkjdfchjlhkgnfjblhclgaliiccalckf?hl=zh-CN"

2) Navigated to chrome flags and enabled  #safe-search-url-reporting
3) Navigated to twitter.com 

EV SSL sign is displayed. Attached screenshot for the same. Adding TE-Verified labels.
EV SSL.png
66.6 KB View Download
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5fed01d5c079bc81e640026b7320b602a8c587

commit 6a5fed01d5c079bc81e640026b7320b602a8c587
Author: spqchan <spqchan@chromium.org>
Date: Wed Aug 31 21:56:49 2016

[Material][Mac] Fix for bubble decoration text in dark theme

BUG= 640511 

Review-Url: https://codereview.chromium.org/2265423007
Cr-Commit-Position: refs/heads/master@{#415062}
(cherry picked from commit 9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd)

Review URL: https://codereview.chromium.org/2302603002 .

Cr-Commit-Position: refs/branch-heads/2840@{#83}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Sign in to add a comment