Issue metadata
Sign in to add a comment
|
EV SSL sign is shown as blank
Reported by
pal...@gmail.com,
Aug 24 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.70 Safari/537.36 Steps to reproduce the problem: Today I just upgrade my browser and found the EV sign(for example, 'Twitter, Inc. [US]' ) turn to whole white. What is the expected behavior? In address bar, before 'https://twitter.com' there should be a clickable 'Twitter, Inc. [US]' button What went wrong? In address bar, before 'https://twitter.com' there is a long blank white button, also clickable Did this work before? N/A Chrome version: 54.0.2837.0 Channel: dev OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0
,
Aug 24 2016
Can you please post a screenshot of the bug? Thanks.
,
Aug 24 2016
It's possible that the font color is incorrect. Are you able to replicate it on incognito or normal?
,
Aug 25 2016
Can't reproduce on Chrome 54.0.2837.0. See attached screenshot. Can you post a screenshot?
,
Aug 25 2016
Also, can you reproduce this on Chrome stable?
,
Aug 25 2016
screenshot: https://i.imgur.com/Lo48Mj5.png Found the reproduce method: 1, chrome 54.0.2837 + (currently dev/canary) 2,install this theme: https://chrome.google.com/webstore/detail/aero-trans-brushed-metal/jkjdfchjlhkgnfjblhclgaliiccalckf?hl=zh-CN 3, open any EV SSL site like twitter or github, the EV sign is all blank, either normal or incognito.
,
Aug 25 2016
Cannot reproduce in stable and beta, with same theme.
,
Aug 25 2016
Verified the instructions in comment 6 and 7. Since this is not reproducible in beta, marking it as a regression.
,
Aug 25 2016
This is how things are supposed to look. We changed the appearance, we have not (yet) changed any functionality.
,
Aug 25 2016
Wait a minute, I looked at the screenshot on comment 4, not comment 6. I don't know why the EV text color would change with a theme installation. It doesn't on views.
,
Aug 25 2016
I'm pretty sure the reason why this is happening is because the EV cert thinks the dark theme = incognito. This should be a quick fix
,
Aug 25 2016
Able to reproduce the issue and issue is a regression broken in M54 only for MAC OS. Below are bisect Details for the same: Bisect info: ============ 54.0.2829.0 - Good Build 54.0.2830.0 - Bad Build Bisect URL: =========== https://chromium.googlesource.com/chromium/src/+log/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6..6546cb056dbfca5975de3fd7dd29015b025f0cf6 Suspecting change #411994, could be the possible culprit.@ spqchan: Assigning to you, request you to please take a look into it. Please help us to reassign if not with respect to your change. Change URL: https://chromium.googlesource.com/chromium/src/+/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72 Review-Url: https://codereview.chromium.org/2241943002 Thanks.!
,
Aug 25 2016
Issue 640785 has been merged into this issue.
,
Aug 26 2016
,
Aug 27 2016
Fix in review:
,
Aug 27 2016
Fix in review: https://codereview.chromium.org/2265423007/
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd commit 9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd Author: spqchan <spqchan@chromium.org> Date: Tue Aug 30 03:52:38 2016 [Material][Mac] Fix for bubble decoration text in dark theme BUG= 640511 Review-Url: https://codereview.chromium.org/2265423007 Cr-Commit-Position: refs/heads/master@{#415062} [modify] https://crrev.com/9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Aug 30 2016
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a5fed01d5c079bc81e640026b7320b602a8c587 commit 6a5fed01d5c079bc81e640026b7320b602a8c587 Author: spqchan <spqchan@chromium.org> Date: Wed Aug 31 21:56:49 2016 [Material][Mac] Fix for bubble decoration text in dark theme BUG= 640511 Review-Url: https://codereview.chromium.org/2265423007 Cr-Commit-Position: refs/heads/master@{#415062} (cherry picked from commit 9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd) Review URL: https://codereview.chromium.org/2302603002 . Cr-Commit-Position: refs/branch-heads/2840@{#83} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Aug 31 2016
,
Sep 1 2016
Rechecked this on chrome version 54.0.2840.8 on MAC 10.11.6. Fix is working as intended. Followed the below steps: Installed chrome and Installed the theme "https://chrome.google.com/webstore/detail/aero-trans-brushed-metal/jkjdfchjlhkgnfjblhclgaliiccalckf?hl=zh-CN" 2) Navigated to chrome flags and enabled #safe-search-url-reporting 3) Navigated to twitter.com EV SSL sign is displayed. Attached screenshot for the same. Adding TE-Verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a5fed01d5c079bc81e640026b7320b602a8c587 commit 6a5fed01d5c079bc81e640026b7320b602a8c587 Author: spqchan <spqchan@chromium.org> Date: Wed Aug 31 21:56:49 2016 [Material][Mac] Fix for bubble decoration text in dark theme BUG= 640511 Review-Url: https://codereview.chromium.org/2265423007 Cr-Commit-Position: refs/heads/master@{#415062} (cherry picked from commit 9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd) Review URL: https://codereview.chromium.org/2302603002 . Cr-Commit-Position: refs/branch-heads/2840@{#83} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/6a5fed01d5c079bc81e640026b7320b602a8c587/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pal...@gmail.com
, Aug 24 2016