Unintuitive design for new developers writing spell checking layout tests |
||||||
Issue descriptionA developer new to spell checking code may write a layout test that expects to see markers under "xyz", and then gets super confused by not seeing them. To write a correct test, the developer either has to know about the mock spell checker and its hard-coded list of misspelled words, or blindly follow the other tests to use magic strings like "zz" while still being confused by why "xyz" doesn't work. A better design may be to allow tests to add misspelled words to the mock spell checker, and then let spell checking tests explicitly add words under which spelling markers are expected. Then a new developer can just follow these tests to write a correct new test without knowing about the mock spell checker.
,
Oct 5 2016
,
Oct 5 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5 2017
,
Oct 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yosin@chromium.org
, Oct 5 2016