New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640506 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 705865



Sign in to add a comment

The webgl2 'texturesize' deqp test fails on macosx

Project Member Reported by jie.a.c...@intel.com, Aug 24 2016

Issue description

Chrome Version       : master tot
URLs (if applicable) :
OS version               : 10.11.6

What steps will reproduce the problem?
(1)launch chrome with --enable-unsafe-es3-apis to enable webgl2
(2)Goto https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html?version=2.0.0
(3)run the deqp/functional/gles3/shadertexturefunction/texturesize.html

What is the expected result?
All cases should pass.

What happens instead?
The cases with lod base all failed.
 
Components: Internals>GPU>WebGL
Status: Untriaged (was: Unconfirmed)
Confirmed on Chrome 52.0.2743.116 Mac 10.11.6. For the  deqp/functional/gles3/shadertexturefunction/texturesize.html test, 1139/1229 tests passed.
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58b47ecc4ef49e2b43526131cdd35ac00055c18

commit e58b47ecc4ef49e2b43526131cdd35ac00055c18
Author: jie.a.chen <jie.a.chen@intel.com>
Date: Fri Aug 26 15:30:53 2016

Add a base mipmap level walkaround for Intel MacOSX

glTexStorage* work incorrectly if the GL_TEXTURE_BASE_LEVEL is not 0.
This CL simply sets it to 0 beforehand and restores it afterward.

BUG= 640506 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2272823004
Cr-Commit-Position: refs/heads/master@{#414719}

[modify] https://crrev.com/e58b47ecc4ef49e2b43526131cdd35ac00055c18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/e58b47ecc4ef49e2b43526131cdd35ac00055c18/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/e58b47ecc4ef49e2b43526131cdd35ac00055c18/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/e58b47ecc4ef49e2b43526131cdd35ac00055c18/gpu/config/gpu_driver_bug_workaround_type.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d21ca543ce703c23daa6d22bb97acae59910bc

commit 02d21ca543ce703c23daa6d22bb97acae59910bc
Author: kbr <kbr@chromium.org>
Date: Sat Aug 27 10:55:32 2016

Suppress dEQP shaderfunction/texturesize on Mac Pros with AMD GPUs.

This test is still failing there.

BUG= 640506 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2281073004
Cr-Commit-Position: refs/heads/master@{#414910}

[modify] https://crrev.com/02d21ca543ce703c23daa6d22bb97acae59910bc/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: Fixed (was: Assigned)

Comment 6 by kbr@chromium.org, Sep 10 2016

Radar 28236120 filed about this bug on Intel GPUs on macOS.

The same bug happens on some Macs with AMD GPUs; at least Mac Pros with device IDs 0x679a and 0x679e. Not MacBook Pro Retinas with mobile AMD GPUs however. Radar 28236328 filed about that. We may consider enabling this workaround on those GPUs.

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e26843bfad416dbeb1d7abf7b0543ff118b9c27e

commit e26843bfad416dbeb1d7abf7b0543ff118b9c27e
Author: kainino <kainino@chromium.org>
Date: Fri Dec 09 23:30:48 2016

apply workaround from 2272823004 to all mac instead of mac intel

BUG= 640506 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566493005
Cr-Commit-Position: refs/heads/master@{#437692}

[modify] https://crrev.com/e26843bfad416dbeb1d7abf7b0543ff118b9c27e/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/e26843bfad416dbeb1d7abf7b0543ff118b9c27e/gpu/config/gpu_driver_bug_list_json.cc

Cc: kbr@chromium.org zmo@chromium.org
Labels: -Pri-3 ReleaseBlock-Beta M-56 Merge-Request-56 Pri-1
We need to merge back commit e26843bfad416dbeb1d7abf7b0543ff118b9c27e
( https://codereview.chromium.org/2566493005 ) to Chrome 56.

This is a very small change to a json file and enables an already well-tested driver bug workaround on some extra platforms.

Comment 9 by dimu@chromium.org, Dec 12 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9dd0aa726a0992e694cf30b40e954246e44e8bb

commit a9dd0aa726a0992e694cf30b40e954246e44e8bb
Author: Kai Ninomiya <kainino@chromium.org>
Date: Mon Dec 12 19:25:14 2016

apply workaround from 2272823004 to all mac instead of mac intel

BUG= 640506 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566493005
Cr-Commit-Position: refs/heads/master@{#437692}
(cherry picked from commit e26843bfad416dbeb1d7abf7b0543ff118b9c27e)

Review-Url: https://codereview.chromium.org/2565233003 .
Cr-Commit-Position: refs/branch-heads/2924@{#465}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a9dd0aa726a0992e694cf30b40e954246e44e8bb/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/a9dd0aa726a0992e694cf30b40e954246e44e8bb/gpu/config/gpu_driver_bug_list_json.cc

Labels: TE-Verified-56.0.2924.28 TE-Verified-M56
Tested the issue on Mac OS 10.11.6 using chrome latest Beta M56-56.0.2924.28 by following steps mentioned in the original comment. Observed that All cases are passed. Hence adding TE-Verified label.

Thank You!


640506.png
294 KB View Download

Comment 12 by zmo@chromium.org, Mar 8 2017

Verified: this bug is fixed in 10.12.4 beta.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62643d9574be80279c2d94868216a8cf9706c11c

commit 62643d9574be80279c2d94868216a8cf9706c11c
Author: zmo <zmo@chromium.org>
Date: Thu Mar 09 01:52:53 2017

Limit reset_base_mipmap_level_before_texstorage driver bug workaround.

To OSX older than 10.12.4.

BUG= 640506 
TEST=
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2733953007
Cr-Commit-Position: refs/heads/master@{#455634}

[modify] https://crrev.com/62643d9574be80279c2d94868216a8cf9706c11c/gpu/config/gpu_driver_bug_list_json.cc

Comment 14 by kbr@chromium.org, Mar 29 2017

Blocking: 705865
Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment