Available space in Files app and Storage manager are inconsistent. |
||||||
Issue descriptionVersion: ToT OS: Chrome OS What steps will reproduce the problem? (1) Open Files app and navigate to Downloads (2) Press 3-vertical-dot button at top-right corner (3) Check the remaining space shown on the menu (4) Open Storage manager by chrome://settings/storage (5) Check the available space shown on the screen. What is the expected output? The space shown in (3) and (5) are consistent. What do you see instead? They are not. In the attached screenshot, Available space shown in Storage manager is 293 MB, but Files app says "0 bytes left". Please use labels and text to provide additional information.
,
Aug 24 2016
Storage manager simply shows |real remaining size|. Files app shows the remaining size using following math. |real remaining size| + |evictable cache size| - 512MB. |evictable cache size| is added because users will be able to use the space by automatic cache eviction. 512MB is subtracted because 512MB is the minimum space. If the real remaining size is 800MB, the actual margin users can use is (800 - 512) = 288MB. By introducing Storage manager, it becomes confusing. I think following options are better now. 1) In Files app, simply show |real remaining size|. It is same as "Available" in Storage manager. 2) In Files app, show |real remaining size| + |evictable cache size|. It is basically same as "Avalable" + "Offline files" in Storage manager. Hiro, WDYT?
,
Aug 24 2016
filled same issue here https://buganizer.corp.google.com/issues/31042070
,
Aug 24 2016
Consistency is a good thing. Let's do this: 1. Change the copy in Files app from xxxGB left to Available 2. Use the same math in Files app as we do in storage management for available space
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e23227790211a07cbb31d711a2a52e313f8fc0d1 commit e23227790211a07cbb31d711a2a52e313f8fc0d1 Author: fukino <fukino@chromium.org> Date: Thu Aug 25 09:17:10 2016 Make chrome.fileManagerPrivate.getSizeStat return actual available space for Downloads. getSizeStat() for Downloads used to return |actual available space| + |evictable Drive cache| - 512MB. To be consistent with Storage manager (chrome://settings/storage), getSizeStat() should simplly return |actual available size|. BUG= 640504 TEST=manually compared the avaiable space in Files app and Storage manager. Review-Url: https://codereview.chromium.org/2274003004 Cr-Commit-Position: refs/heads/master@{#414371} [modify] https://crrev.com/e23227790211a07cbb31d711a2a52e313f8fc0d1/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/e23227790211a07cbb31d711a2a52e313f8fc0d1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc [modify] https://crrev.com/e23227790211a07cbb31d711a2a52e313f8fc0d1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
,
Aug 25 2016
Thanks Hiro, Jonny! The change described in c#5 has landed. Closing...
,
Aug 29 2016
,
Sep 2 2016
Now storage space is same in Files app and Storage manager. But its not consistent with settings-> android preference-> storage. Verified on Chrome:54.0.2840.10/Chromeos:8743.8.0.
,
Sep 13 2016
Is this going into M53? They don't match for me in latest 8530.84.0
,
Sep 14 2016
I suppose it's not going to be merged to M53 as it is P2. mitsuji@, could you double check? Should we ask a merge for M53?
,
Sep 14 2016
Hmm, that's a shame, I thought this change was merged into M53. At this point it's a bit late IMO, can we treat this as a bug fix in M54?
,
Sep 15 2016
M54 already has the fix. (The fix landed on the M54 branch cut day) Let me keep this as Fixed and M-54 label for this.
,
Oct 4 2016
Verified on build 8861.0.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, Aug 24 2016