Issue metadata
Sign in to add a comment
|
iOS Page Info: no icon/indentation for mixed content |
||||||||||||||||||||||||
Issue descriptionVersion: 54.0.232.0 OS: iOS What steps will reproduce the problem? (1) Visit mixed.badssl.com (2) Click on the page/lock icon. What is the expected output? The mixed content explanation has an icon and is indented the same as the main explanation. What do you see instead? No icon, no indentation. (observed.png) The lack of icon isn't too bad, but the lack of indentation looks weird. I noticed his while fixing https://crbug.com/637814 and it's a one-line fix to cover this, too. I'm going to go with the info icon rather than the bad icon, since that will match the lock icon once Issue 634938 is fixed. felt@, maxwalker@: if you feel strongly, let me know and I can easily change.
,
Aug 24 2016
Agreed, that the mixed content section should be indented, too. Using the info icon SGTM.
,
Sep 14 2016
,
Sep 14 2016
,
Oct 19 2016
,
Oct 20 2016
,
Nov 16 2016
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6dd3781121d6a697d9d525e9d965f38c72b8df0 commit a6dd3781121d6a697d9d525e9d965f38c72b8df0 Author: lgarron <lgarron@chromium.org> Date: Fri Jan 20 01:23:58 2017 Update Page Info on iOS to an interim Material Design state. This brings it mostly in sync with other platforms by replacing two sections (identity info and connection info) with a single section containing a security summary and a sentence with details about what the security state means. This CL also: - Drops logic to show error strings related to and SHA-1 deprecation, since we don't detail this on desktop and some of these states can't even be detected on WKWebView anymore. - Preserves the layout code for multiple sections, even if we only show a single one now. - Preserves certificate information for devs/power users, since there is no other way to get the info until we have a certificate viewer on iOS (crbug.com/502470). BUG= 680784 , 656843 , 640478 TEST=Visit the following sites and check against the screenshots at crbug.com/680784#c1 : - expired.badssl.com (on iPhone) - mixed.badssl.com (on iPhone) - http-login.badssl.com (on iPhone) - www.google.com (on iPhone) - http.badssl.com (on iPad) Review-Url: https://codereview.chromium.org/2620243005 Cr-Commit-Position: refs/heads/master@{#444919} [modify] https://crrev.com/a6dd3781121d6a697d9d525e9d965f38c72b8df0/ios/chrome/browser/ui/omnibox/page_info_model.cc
,
Jan 24 2017
,
Feb 10 2017
,
Feb 15 2017
Indentation and content is now updated for mixed state webpages. Verified on M57.0.2987.53 beta Device: iPhone7, iPad Pro iOS: 10.3, 10.1.1 Screenshot: https://drive.google.com/file/d/0B-xmXLQhjeKuVlktUElYMTEyLWs/view |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Aug 24 2016