chromite: gs: update to gsutil 4.21 |
|||||||
Issue descriptionDue to Issue 639314, we downgraded gsutil from 4.21 to 4.19. gsutil 4.19->4.20 was done in this CL: https://chromium-review.googlesource.com/372342 gsutil 4.20->4.21 was done in this CL: https://chromium-review.googlesource.com/373073 We probably want to upgrade again, without breaking our -release builders again.
,
Aug 24 2016
,
Aug 24 2016
seems to me the problem is that platform/dev/ has its own gsutil wrapper module that needs to be thrown away and replaced with chromite.lib.gs. filed issue 640609 to track.
,
Aug 24 2016
Chromite isn't always available to platform/dev, but xixuan is working on fixing that.
,
Aug 15 2017
#4 is there a separate bug for that? Also, I didn't find this bug and I filed a quasi-duplicate (the current version is 4.27). I searched for "gsutil version". OK done, now I'll find it! Is this NOT chrome-os-specific? I am also adding the Build component, please correct if wrong.
,
Aug 16 2017
issue 709650 tracks the single user of gsutil_util -- autotest/files/site_utils/autoupdate/ this is CrOS specific since we're talking about chromite.lib.gs
,
Aug 16 2017
The chromite.lib.gs pin of gsutil is replicated other places. I THINK we are supposed to be safe up update generally now, but I'm not certain. xixuan@ can speak to that.
,
Aug 16 2017
Updating to the current version makes the unit tests fail. See issue 755724 , comment copied below. ---------------------- The Google Storage team has released gsutil version 4.27 but we're still using 4.19. One problem is that whenever we file gsutil-related bugs, that team won't even look at them because the version is too old. Unfortunately changing version makes the unit tests fail: gs_unittest fails with 4 errors gs_unittest --network fails with 28 errors
,
Aug 16 2017
> The chromite.lib.gs pin of gsutil is replicated other places. i'm not sure what you're referring to there. we only care about chromite.lib.gs being up to date. if projects (like cros-signing) are pinning older versions of chromite, that's their responsibility to update the pin from time to time (as gsutil isn't the only thing in there). that's not something anyone updating chromite.lib.gs has to be concerned about imo.
,
Aug 16 2017
All functions in platform/dev now uses gsutil in chromite.lib. but autotest has a user to use gsutil in dev, is it a blocker for upgrade gsutil? From crbug.com/639314 I feel the answer is yes.
,
Aug 16 2017
> Unfortunately changing version makes the unit tests fail: yes, that's "normal" :). anyone who wants to update gsutil has to go through the pain of dealing with changes to gsutil's CLI, output format, etc... it's why our tests are so extensive -- we need the python API to be stable even though the gsutil itself is not. so that's why i haven't gotten around to doing the upgrade. it takes time. if someone else wants to shave the yak, feel free to jump on it (i'm fairly certain one rides the yak while shaving it).
,
Aug 30 2017
Lab has problems with gsutil this morning. Nothing weird from our side of metrics, so we guess it's problem with gsutil. Maybe it's the time to upgrade it again. Which version do we want to upgrade to?
,
Aug 30 2017
unless we have specific knowledge of a problem in a specific version, pref is always to go to the latest version. we get push back from the GS guys with bug reports if we aren't using that.
,
Aug 30 2017
semenzato@ we didn't upgrade past 4.19 because of a change in the command line semantics that required library updates to match, and coordinating those changes everwhere was hard. So.... after updating the pin, we'll also have to update lib/gs.py to match.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9e2f6cc0b698872b0fe7bf7863de844ded5fce63 commit 9e2f6cc0b698872b0fe7bf7863de844ded5fce63 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Sep 08 04:21:41 2017 gsutil: upgrade from 4.19 to 4.27 BUG= chromium:640476 TEST='./lib/gs_unittest --network' passes TEST='./lib/paygen/gslib_unittest --network' passes TEST='./lib/paygen/gslock_unittest --network' passes TEST='./lib/paygen/gspaths_unittest --network' passes Change-Id: I4bdb25524ae8b388491894756f9445a03b9d94cb Reviewed-on: https://chromium-review.googlesource.com/653370 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/9e2f6cc0b698872b0fe7bf7863de844ded5fce63/lib/gs.py
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7901ea1a0de59bc5f51dd5536654531244e5e202 commit 7901ea1a0de59bc5f51dd5536654531244e5e202 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Sep 08 04:21:30 2017 gs: LS: fix local usage in --debug mode Make sure we don't rely on implicit settings for output capture. BUG= chromium:640476 TEST=`./lib/gs_unittest --debug` passes Change-Id: I6dc8772fa4ee46d99e0fa7a478c9ebaca4457075 Reviewed-on: https://chromium-review.googlesource.com/656104 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/7901ea1a0de59bc5f51dd5536654531244e5e202/lib/gs.py
,
Mar 19 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/eff2eb7222fb93f26e7fe9c0a9bf4fbc9ef0f524 commit eff2eb7222fb93f26e7fe9c0a9bf4fbc9ef0f524 Author: Mike Frysinger <vapier@chromium.org> Date: Thu May 10 09:29:19 2018 gs: LS: fix local usage in --debug mode Make sure we don't rely on implicit settings for output capture. BUG= chromium:640476 TEST=`./lib/gs_unittest --debug` passes Change-Id: I6dc8772fa4ee46d99e0fa7a478c9ebaca4457075 Reviewed-on: https://chromium-review.googlesource.com/656104 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> (cherry picked from commit 7901ea1a0de59bc5f51dd5536654531244e5e202) Reviewed-on: https://chromium-review.googlesource.com/1053707 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/eff2eb7222fb93f26e7fe9c0a9bf4fbc9ef0f524/lib/gs.py
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/892fb73b8101f4c8f537678d099173e1aa657cd8 commit 892fb73b8101f4c8f537678d099173e1aa657cd8 Author: Xixuan Wu <xixuan@chromium.org> Date: Thu May 10 09:32:15 2018 gsutil: upgrade from 4.19 to 4.27 BUG= chromium:640476 TEST='./lib/gs_unittest --network' passes TEST='./lib/paygen/gslib_unittest --network' passes TEST='./lib/paygen/gslock_unittest --network' passes TEST='./lib/paygen/gspaths_unittest --network' passes Change-Id: I4bdb25524ae8b388491894756f9445a03b9d94cb Reviewed-on: https://chromium-review.googlesource.com/653370 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 9e2f6cc0b698872b0fe7bf7863de844ded5fce63) Reviewed-on: https://chromium-review.googlesource.com/1053708 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/892fb73b8101f4c8f537678d099173e1aa657cd8/lib/gs.py |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 Deleted