Pasted text not spell checked when the root editable element of the pasting target starts with invisible node |
||||
Issue descriptionVersion: ToT 54.0.2838.0 OS: All What steps will reproduce the problem? (1) Open https://jsfiddle.net/ym5k328q/1/ (2) Copy the first line "misssspelllled wordds tto ccopy." (3) Paste into the first "[]" (4) Then Paste into the second "[]" What is the expected output? After step (4), red markers appear immediately under the misspelled words, just like after step (3). What do you see instead? No marker appear after step (4) (unless we do some other action to trigger spell checking again) Please use labels and text to provide additional information.
,
Aug 24 2016
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7168dd4011adfe053b7a5c0f308fcf7b1495b31b commit 7168dd4011adfe053b7a5c0f308fcf7b1495b31b Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Aug 24 11:53:13 2016 Stop SpellCheckRequest from checking canCheckAsynchronously() This patch removes static function canCheckAsynchronously() from SpellCheckRequester.cpp and stops SpellCheckRequest from calling it. The removed function is legacy code from the old age before the removal of synchronous spell checking. In addition, the items checked by this function do not make much sense now -- either incorrect or redundant. Hence, the function is removed. This patch is also a preparation for reducing the use of TextCheckingParagraph: http://crrev.com/2273453003 BUG= 640456 TEST=editing/spelling/paste_into_element_starting_with_invisible.html Review-Url: https://codereview.chromium.org/2248413003 Cr-Commit-Position: refs/heads/master@{#414049} [add] https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b/third_party/WebKit/LayoutTests/editing/spelling/paste_into_element_starting_with_invisible.html [modify] https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp [modify] https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp [modify] https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
,
Aug 25 2016
,
Apr 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xiaoche...@chromium.org
, Aug 24 2016