This is the first step in removing PassRefPtr ( issue 494719 )
PassRefPtr will be made move-only and std::move calls will be added to all places where the PassRefPtr copy constructor is currently called (when passing a PassRefPtr to a method expecting a PassRefPtr).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81fd4d944c6a8920f58af346722499425ed4a7b3 commit 81fd4d944c6a8920f58af346722499425ed4a7b3 Author: bugsnash <bugsnash@chromium.org> Date: Tue Aug 30 04:11:05 2016 Replaced PassRefPtr copies with moves in Source/core/animation. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2286233002 Cr-Commit-Position: refs/heads/master@{#415077} [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/BasicShapePropertyFunctions.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/InterpolableValue.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/InterpolationEffect.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/ShadowListPropertyFunctions.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/StringKeyframe.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/StringKeyframe.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatablePath.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp [modify] https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c42809bbfc31acfe4a3d665515b5e0fa81ce1f30 commit c42809bbfc31acfe4a3d665515b5e0fa81ce1f30 Author: bugsnash <bugsnash@chromium.org> Date: Tue Aug 30 04:55:56 2016 Added move constructor to PassRefPtr. This is the first step in making PassRefPtr move only, in preparation for removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2274793002 Cr-Commit-Position: refs/heads/master@{#415123} [modify] https://crrev.com/c42809bbfc31acfe4a3d665515b5e0fa81ce1f30/third_party/WebKit/Source/wtf/PassRefPtr.h [add] https://crrev.com/c42809bbfc31acfe4a3d665515b5e0fa81ce1f30/third_party/WebKit/Source/wtf/PassRefPtrTest.cpp [modify] https://crrev.com/c42809bbfc31acfe4a3d665515b5e0fa81ce1f30/third_party/WebKit/Source/wtf/wtf.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7 commit 9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7 Author: bugsnash <bugsnash@chromium.org> Date: Mon Sep 05 06:38:29 2016 Replaced PassRefPtr copies with moves in Source/core. Only did replace outside of Source/core/animation, which is already handled in https://codereview.chromium.org/2286233002. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2282413002 Cr-Commit-Position: refs/heads/master@{#416506} [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/clipboard/DataObject.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/css/CSSPathValue.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/DOMArrayBuffer.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/DOMDataView.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/DOMTypedArray.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/dom/RemoteSecurityContext.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/events/MessageEvent.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/events/PopStateEvent.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/fileapi/Blob.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/fileapi/File.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/fileapi/File.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/FrameSerializer.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/History.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/History.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/ImageBitmap.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/html/forms/ImageInputType.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/LayoutTextCombine.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/api/LayoutItem.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/api/LayoutTextFragmentItem.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/api/LayoutTextItem.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/style/ClipPathOperation.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/style/ComputedStyle.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/style/ShapeValue.h [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp [modify] https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85df4ce3945fa1413d991881b1281802442c16a8 commit 85df4ce3945fa1413d991881b1281802442c16a8 Author: bugsnash <bugsnash@chromium.org> Date: Mon Sep 05 23:02:11 2016 Replaced PassRefPtr copites with moves in Source/modules. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2308343002 Cr-Commit-Position: refs/heads/master@{#416565} [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/cachestorage/Cache.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/canvas2d/CanvasPattern.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/canvas2d/CanvasPattern.h [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/Body.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/indexeddb/IDBAny.h [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/indexeddb/IDBKey.h [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/plugins/DOMMimeType.h [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp [modify] https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/009459a350906e2c49d20f4f7ee17c7b29c488e8 commit 009459a350906e2c49d20f4f7ee17c7b29c488e8 Author: bugsnash <bugsnash@chromium.org> Date: Mon Sep 05 23:03:33 2016 Replaced PassRefPtr copies with moves in Source/platform. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2306293002 Cr-Commit-Position: refs/heads/master@{#416566} [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/Length.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/PODArena.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/PODFreeListArena.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/blob/BlobData.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/fonts/SimpleFontData.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/Pattern.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/filters/FEDiffuseLighting.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp [modify] https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8/third_party/WebKit/Source/platform/network/EncodedFormData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e4e8c6fb5346db13860874efb6d988af79eb408 commit 5e4e8c6fb5346db13860874efb6d988af79eb408 Author: bugsnash <bugsnash@chromium.org> Date: Wed Sep 14 05:43:51 2016 Replaced PassRefPtr copies with moves in Source/web and Source/wtf. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2308353002 Cr-Commit-Position: refs/heads/master@{#418493} [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Float32Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Float64Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Int16Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Int32Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Int8Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/IntegralTypedArrayBase.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Uint16Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Uint32Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h [modify] https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408/third_party/WebKit/Source/wtf/typed_arrays/Uint8ClampedArray.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b54afe50728088d9434c02a9f8cca6d7180226d commit 0b54afe50728088d9434c02a9f8cca6d7180226d Author: bugsnash <bugsnash@chromium.org> Date: Wed Sep 21 21:53:12 2016 Replaced PassRefPtr copies with moves. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. The PassRefPtr copies in this patch were those that were more difficult to find (those involved in templates and cross thread) and new ones added since previous patches. BUG= 640449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2359553003 Cr-Commit-Position: refs/heads/master@{#420173} [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/dom/ElementRareData.h [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/style/StyleVariableData.h [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/platform/Length.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/platform/audio/AudioDestination.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp [modify] https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be469c01f9657a1598ba00423f26279e2c24f0c9 commit be469c01f9657a1598ba00423f26279e2c24f0c9 Author: bugsnash <bugsnash@chromium.org> Date: Tue Sep 27 06:21:23 2016 Disallowed PassRefPtr copies across threads. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. Overrode CrossThreadCopier<PassRefPtr>::copy taking an rvalue, disallowing lvalues of PassRefPtr to be passed in. Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in std::move to ensure an rvalue is returned. This is necessary to prevent PassRefPtr copies where a PassRefPtr object is constructed inside the call to CrossThreadCopier::copy, e.g. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp?l=215 BUG= 640449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2355153002 Cr-Commit-Position: refs/heads/master@{#421127} [modify] https://crrev.com/be469c01f9657a1598ba00423f26279e2c24f0c9/third_party/WebKit/Source/platform/CrossThreadCopier.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a commit e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a Author: bugsnash <bugsnash@chromium.org> Date: Wed Oct 19 20:27:43 2016 Replaced PassRefPtr copies with moves in unit tests. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://chromiumcodereview.appspot.com/2432883002 Cr-Commit-Position: refs/heads/master@{#426269} [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/platform/PODFreeListArena.h [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/platform/fonts/GlyphPageTreeNodeTest.cpp [modify] https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b commit f26988b540a3d5293179ddb7e9d5fc5203dcfb8b Author: bugsnash <bugsnash@chromium.org> Date: Mon Oct 24 06:32:46 2016 Made PassRefPtr move only and replaced new copies with moves. Removed PassRefPtr copy constructor. Added move wraps for remaining PassRefPtr copies (newly introduced). BUG= 640449 Review-Url: https://codereview.chromium.org/2437883002 Cr-Commit-Position: refs/heads/master@{#427020} [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/core/css/PropertyRegistry.cpp [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/core/style/StyleNonInheritedVariables.h [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.cpp [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.h [modify] https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b/third_party/WebKit/Source/wtf/PassRefPtr.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a44821bd6c02f83896fe03e842f9982703c6b15 commit 9a44821bd6c02f83896fe03e842f9982703c6b15 Author: bugsnash <bugsnash@chromium.org> Date: Tue May 09 04:43:25 2017 Changed PassRefPtr templated copy constructor to move constructor. Changed argument in PassRefPtr constructor that takes a PassRefPtr with a different inner type from a const lvalue to an rvalue, making the constructor a move constructor instead of a copy constructor and forbidding PassRefPtr copies when the inner type is different. Added move wraps to call sites to ensure they pass rvalues. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG= 640449 Review-Url: https://codereview.chromium.org/2867693003 Cr-Commit-Position: refs/heads/master@{#470219} [modify] https://crrev.com/9a44821bd6c02f83896fe03e842f9982703c6b15/third_party/WebKit/Source/core/dom/DOMTypedArray.h [modify] https://crrev.com/9a44821bd6c02f83896fe03e842f9982703c6b15/third_party/WebKit/Source/platform/wtf/PassRefPtr.h [modify] https://crrev.com/9a44821bd6c02f83896fe03e842f9982703c6b15/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
Comment 1 by bugsnash@chromium.org
, Aug 24 2016Components: Blink>Internals