There's gotta be a lot of SVN-specific code, especially in tools like bugdroid and other py_issue_tracker stuff. Get rid of it all.
Three CLs to turn off bugdroid: https://chromereviews.googleplex.com/491267014 https://chromereviews.googleplex.com/495697014 https://chromereviews.googleplex.com/495077013 Deleting SVN support from py_issue_tracker/bugdroid will come next
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config.git/+/c38ec0849de5a90b2f053316fe0ed627add7f78f commit c38ec0849de5a90b2f053316fe0ed627add7f78f Author: Aaron Gable <agable@chromium.org> Date: Wed Aug 24 16:32:32 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/dcc942dd29df7c8d5a9ea88981ec9394708369ef commit dcc942dd29df7c8d5a9ea88981ec9394708369ef Author: agable <agable@google.com> Date: Wed Aug 24 16:54:48 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/6b3df61b86345b63fdd5b3628008ff8b79dc396b commit 6b3df61b86345b63fdd5b3628008ff8b79dc396b Author: agable <agable@google.com> Date: Wed Aug 24 16:55:49 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/f0142aa38a3777fa0230129c87bf0fad1afa94e2 commit f0142aa38a3777fa0230129c87bf0fad1afa94e2 Author: agable <agable@google.com> Date: Mon Aug 29 23:22:32 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/0e0abefbeca61b46eb5124e0e50feaef118706a6 commit 0e0abefbeca61b46eb5124e0e50feaef118706a6 Author: agable <agable@google.com> Date: Mon Aug 29 23:47:18 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/1ac7eed3175c5d2c17056f8719d211fe31ceeffc commit 1ac7eed3175c5d2c17056f8719d211fe31ceeffc Author: agable <agable@google.com> Date: Wed Aug 31 18:21:40 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/2240730db3190ae6f5a334bedb9a4fe3138d58bb commit 2240730db3190ae6f5a334bedb9a4fe3138d58bb Author: agable <agable@google.com> Date: Thu Sep 01 00:41:30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/d69e599284e13faaad2cbd39805066b71f5d5f3c commit d69e599284e13faaad2cbd39805066b71f5d5f3c Author: agable <agable@google.com> Date: Fri Sep 02 20:59:45 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3d030c1f5787a736df7123eb35d5971a2df9dadb commit 3d030c1f5787a736df7123eb35d5971a2df9dadb Author: agable <agable@google.com> Date: Fri Sep 02 21:17:49 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/165f90940eac7f4af75f11d3c64926efe35f1e23 commit 165f90940eac7f4af75f11d3c64926efe35f1e23 Author: Aaron Gable <agable@chromium.org> Date: Fri Sep 02 21:23:19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3b2e59dfe153996affa528e61749b94fedda405e commit 3b2e59dfe153996affa528e61749b94fedda405e Author: agable <agable@google.com> Date: Fri Sep 02 22:42:30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bd5373975777fcbd53ef6283d52402ffb8013376 commit bd5373975777fcbd53ef6283d52402ffb8013376 Author: agable <agable@google.com> Date: Tue Sep 06 17:35:35 2016
The three main sources of SVN in infra_internal are rietveld/upload.py: Will port from external after that lands omahaproxy: https://chromereviews.googleplex.com/504647013/ commit_queue: https://chromereviews.googleplex.com/501047013 The main sources of SVN in infra are rietveld/upload.py: https://chromium-review.googlesource.com/381694 gnumbd: https://chromium-review.googlesource.com/381575 cr-rev: Not removing for backwards compatibility findit: https://chromium-review.googlesource.com/381751 monorail: https://chromium-review.googlesource.com/381672 som: https://chromium-review.googlesource.com/381572
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/2c0858aead4ad167d4125de95899ba3092c56041 commit 2c0858aead4ad167d4125de95899ba3092c56041 Author: Aaron Gable <agable@chromium.org> Date: Tue Sep 06 20:29:38 2016 Remove svn support from SoM BUG= 640438 Change-Id: I0f3ad01f4fafe6dbc8e86a88096b6bb67abb27d3 Reviewed-on: https://chromium-review.googlesource.com/381572 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/2c0858aead4ad167d4125de95899ba3092c56041/appengine/sheriff_o_matic/model/ct-commit-mock.html [modify] https://crrev.com/2c0858aead4ad167d4125de95899ba3092c56041/appengine/sheriff_o_matic/model/ct-commit.html [modify] https://crrev.com/2c0858aead4ad167d4125de95899ba3092c56041/appengine/sheriff_o_matic/model/test/ct-commit-tests.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/c697b3797d6e05cb3ce31351dd482c38d6646261 commit c697b3797d6e05cb3ce31351dd482c38d6646261 Author: Aaron Gable <agable@chromium.org> Date: Wed Sep 07 00:51:11 2016 Remove SVN support from findit BUG= 640438 Change-Id: Iec2017a713e675196df4c8611ca5ca29ecf26ec9 Reviewed-on: https://chromium-review.googlesource.com/381751 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/c697b3797d6e05cb3ce31351dd482c38d6646261/appengine/findit/common/chromium_deps.py [modify] https://crrev.com/c697b3797d6e05cb3ce31351dd482c38d6646261/appengine/findit/common/git_repository.py [modify] https://crrev.com/c697b3797d6e05cb3ce31351dd482c38d6646261/appengine/findit/common/test/chromium_deps_test.py [modify] https://crrev.com/c697b3797d6e05cb3ce31351dd482c38d6646261/appengine/findit/common/test/git_repository_test.py [modify] https://crrev.com/c697b3797d6e05cb3ce31351dd482c38d6646261/appengine/findit/waterfall/test/pull_changelog_pipeline_test.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/dd3bc2203e31f2e9a0ea737bbea9ce884ec9b73b commit dd3bc2203e31f2e9a0ea737bbea9ce884ec9b73b Author: agable <agable@google.com> Date: Wed Sep 07 22:16:09 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/50841cafc738385c07c2ae78c36f07671e18304f commit 50841cafc738385c07c2ae78c36f07671e18304f Author: Aaron Gable <agable@chromium.org> Date: Tue Sep 06 22:45:33 2016 Remove svn/hg/cvs/p4 support from Rietveld's upload.py BUG= 640438 Change-Id: I23070c7d629794c523962f39e374673bfe58f857 Reviewed-on: https://chromium-review.googlesource.com/381694 Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/50841cafc738385c07c2ae78c36f07671e18304f/appengine/chromium_rietveld/upload.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/95626accc6a88a4437b7c5cc629ceeb4d65097c1 commit 95626accc6a88a4437b7c5cc629ceeb4d65097c1 Author: Aaron Gable <agable@chromium.org> Date: Fri Sep 09 23:42:41 2016 Remove git-svn support from gnumbd BUG= 640438 Change-Id: I8407ba4128f09840d5f2d0b3d174c6cca30b4d29 Reviewed-on: https://chromium-review.googlesource.com/381575 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/gnumbd.py [delete] https://crrev.com/a5b63f3ca38544d50d39bf85be22dd920e59b63a/infra/services/gnumbd/test/gnumbd_test.expected/bad_svn_footer.yaml [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/test/gnumbd_test.expected/branch.yaml [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/test/gnumbd_test.expected/branch_from_branch.yaml [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/test/gnumbd_test.expected/extra_user_footer_bad.yaml [delete] https://crrev.com/a5b63f3ca38544d50d39bf85be22dd920e59b63a/infra/services/gnumbd/test/gnumbd_test.expected/incoming_svn_id_drops.yaml [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/test/gnumbd_test.expected/no_position_footer.yaml [delete] https://crrev.com/a5b63f3ca38544d50d39bf85be22dd920e59b63a/infra/services/gnumbd/test/gnumbd_test.expected/svn_mode_uses_svn_rev.yaml [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gnumbd/test/gnumbd_test_definitions.py [modify] https://crrev.com/95626accc6a88a4437b7c5cc629ceeb4d65097c1/infra/services/gsubtreed/gsubtreed.py
Some more CLs: event_mon - https://chromium-review.googlesource.com/393766 lkgr_finder - https://chromium-review.googlesource.com/393846 contributing.md - https://chromium-review.googlesource.com/393807 Once those are done, the only remaining service I'm going to consider important is the CQ, for which I'll file a separate bug.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/da79254a11747f82f314a543d78c4eae271a5229 commit da79254a11747f82f314a543d78c4eae271a5229 Author: Aaron Gable <agable@chromium.org> Date: Wed Oct 05 18:04:10 2016 Remove svn troubleshooting from contributing doc BUG= 640438 Change-Id: Ia3e2d5c9bb3f2a38ed463276190cca38cc2699a7 Reviewed-on: https://chromium-review.googlesource.com/393807 Reviewed-by: Ben Henry <benhenry@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/da79254a11747f82f314a543d78c4eae271a5229/doc/contributing.md
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/828603b4944ab24a8e26eaef9b68508c3cf163b7 commit 828603b4944ab24a8e26eaef9b68508c3cf163b7 Author: Aaron Gable <agable@chromium.org> Date: Wed Oct 05 19:58:19 2016 Remove SVN version support from event_mon BUG= 640438 Change-Id: Ieb366013243743f3f7536de96820316387562884 Reviewed-on: https://chromium-review.googlesource.com/393766 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> [modify] https://crrev.com/828603b4944ab24a8e26eaef9b68508c3cf163b7/infra/tools/send_monitoring_event/test/data/revinfo.txt [modify] https://crrev.com/828603b4944ab24a8e26eaef9b68508c3cf163b7/packages/infra_libs/infra_libs/event_mon/checkouts.py [modify] https://crrev.com/828603b4944ab24a8e26eaef9b68508c3cf163b7/packages/infra_libs/infra_libs/event_mon/monitoring.py [modify] https://crrev.com/828603b4944ab24a8e26eaef9b68508c3cf163b7/packages/infra_libs/infra_libs/event_mon/test/checkouts_test.py [modify] https://crrev.com/828603b4944ab24a8e26eaef9b68508c3cf163b7/packages/infra_libs/infra_libs/event_mon/test/monitoring_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/b24a953db287b83c6725422537fad5e869d7c073 commit b24a953db287b83c6725422537fad5e869d7c073 Author: Aaron Gable <agable@chromium.org> Date: Tue Oct 11 22:59:45 2016 Remove SVN support from lkgr_finder BUG= 640438 Change-Id: Ic76b404f859f32d1c7b6d18a53dab25bbb6bae2e Reviewed-on: https://chromium-review.googlesource.com/393846 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/__main__.py [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/config/blink_cfg.pyl [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/config/chromium_cfg.pyl [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/config/chromium_lkcr_cfg.pyl [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/config/v8_cfg.pyl [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/config/webrtc_cfg.pyl [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/lkgr_lib.py [modify] https://crrev.com/b24a953db287b83c6725422537fad5e869d7c073/infra/services/lkgr_finder/test/lkgr_lib_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/7b3cb63f033b0a52a05161e6e16b9d672db27fa1 commit 7b3cb63f033b0a52a05161e6e16b9d672db27fa1 Author: Aaron Gable <agable@chromium.org> Date: Fri Oct 28 18:48:01 2016 Reland "Remove SVN support from lkgr_finder" This reverts commit ee8f9101e6503deea5c24c0d8a5eb6347d4c0d5a. BUG= 640438 Change-Id: I8d7252365c3705c9fb593a5cc677d3e07ee21071 Reviewed-on: https://chromium-review.googlesource.com/404556 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/__main__.py [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/config/blink_cfg.pyl [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/config/chromium_cfg.pyl [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/config/chromium_lkcr_cfg.pyl [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/config/v8_cfg.pyl [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/config/webrtc_cfg.pyl [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/lkgr_lib.py [modify] https://crrev.com/7b3cb63f033b0a52a05161e6e16b9d672db27fa1/infra/services/lkgr_finder/test/lkgr_lib_test.py
Comment 1 by aga...@chromium.org
, Aug 24 2016