WebAPK crashes on launch on Jellybean at WebApkUpdateManager#updateIfNeeded() |
||
Issue descriptionBased on preliminary investigation, it looks like WebappRegistry#getWebappDataStorage() returns null
,
Sep 12 2016
Peter, could you please verify whether it is still crash on Jellybean?
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be21c85ff9c6e897496e1731a76e9ef24af600ac commit be21c85ff9c6e897496e1731a76e9ef24af600ac Author: hanxi <hanxi@chromium.org> Date: Thu Sep 15 20:16:17 2016 Fix WebAPK crashes on launch on Jellybean. The crash is caused by using getId() instead of mWebappInfo.id() when registering WebAPK. WebApkManagedActivity is launched on Jellybean instead of WebApkActivity, and getId() in WebApkManagedActivity returns the index of the managered activity, rather than the Webapp id. BUG= 640434 Review-Url: https://codereview.chromium.org/2339623002 Cr-Commit-Position: refs/heads/master@{#418949} [modify] https://crrev.com/be21c85ff9c6e897496e1731a76e9ef24af600ac/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java [modify] https://crrev.com/be21c85ff9c6e897496e1731a76e9ef24af600ac/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkManagedActivity.java [modify] https://crrev.com/be21c85ff9c6e897496e1731a76e9ef24af600ac/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java [modify] https://crrev.com/be21c85ff9c6e897496e1731a76e9ef24af600ac/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappManagedActivity.java
,
Sep 15 2016
,
Oct 28 2016
Test steps: 1) Uninstall any currently installed "test WebAPKs" (APKs with yellow hexagon) 2) Enable WebAPKs by following steps in https://docs.google.com/a/google.com/document/d/1gHZ1YXO7QRZO6hgt11uqItNpl5WrZBJYxPYAnuJphXU/edit?usp=sharing 3) "Force Stop" Chrome 4) In Chrome for Android, navigate to goo.gl/36GSsH 5) Select "Add to Home screen" from the app menu. An infobar will show briefly. Press the "Install" button when asked to install the "Simple Test" APK 6) Launch the newly created APK. 7) Check that there is no crash |
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Aug 24 2016