New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640432 link

Starred by 2 users
Status: Verified
Owner:
azurewei@chromium.org
Closed: Aug 2016
Cc:
shuchen@chromium.org
█ xiangye@chromium.org
wuyingbing@chromium.org
█ msrchandra@chromium.org
xiulingw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

The list of IMEs in opt-in IME menu could not update with shortcuts

Project Member Reported by azurewei@chromium.org, Aug 24 2016 
OS: ChromeOS

What steps will reproduce the problem?
(1) Enable the flag "Enable opt-in IME menu" in about://flags page.
(2) Open "language and input" settings page, check the box with label "Show input options in the shelf".
(3) Open opt-in IME menu
(4) Switch IME with "Ctrl+Alt+Space" or "Ctrl+Space".

What is the expected output?

The IME list updates with switching the current IME.

What do you see instead?

The IME list has not updated.

Comment 1 by zhan...@chromium.org, Aug 25 2016

Cc: wuyingbing@chromium.org shuchen@chromium.org xiangye@chromium.org xiulingw@chromium.org
Labels: InputTools-54 M-54 OS-Linux
Check it in M54-8738 clapper;

Still repro , after clicking  ctrl+space or ctrl+shift+space shortcut key , opt-in IME can not update at once, need to close menu then open it again, IME list can update;

Only ime icon in the shelf can update immediately
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7017855217bfc5d4ea11d44e526373bd7c571dac

commit 7017855217bfc5d4ea11d44e526373bd7c571dac
Author: johnme <johnme@chromium.org>
Date: Thu Aug 25 11:00:26 2016

Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )

Reason for revert:
ImeMenuTrayTest.RefreshImeWithListViewCreated is failing consistently on https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15622

Original issue's description:
> Updates the IME list when the IME has refreshed.
>
> When the IME refreshes, we need to update the view of the list in IME menu.
> Saves the created ImeListView and updates it when get IME refreshing event.
> Add ImeMenuTrayTest.RefreshImeWithListViewCreated test.
>
> BUG= 640432 
> TEST=Verified on local build.
>
> Committed: https://crrev.com/c6f28a1effd401fd7e2e03707e0dd84f5346185b
> Cr-Commit-Position: refs/heads/master@{#414329}

TBR=jamescook@chromium.org,azurewei@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 640432 

Review-Url: https://codereview.chromium.org/2281473002
Cr-Commit-Position: refs/heads/master@{#414388}

[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac/ash/test/test_system_tray_delegate.h
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6200ab48ee282cae1460dfd1aaeafbf732897d6

commit c6200ab48ee282cae1460dfd1aaeafbf732897d6
Author: azurewei <azurewei@chromium.org>
Date: Fri Aug 26 21:42:30 2016

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )"

This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac.

Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production.

Fix the underlying crash problem and add new test:
ImeMenuTrayTest.QuitChromeWithMenuOpen
to cover it.

BUG= 640432 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2277753006
Cr-Commit-Position: refs/heads/master@{#414819}

[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6/ash/test/test_system_tray_delegate.h

Comment 5 by azurewei@chromium.org, Aug 27 2016

Status: Fixed (was: Assigned)

Comment 6 by zhan...@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
Verified in M55-8749 clapper

Comment 7 by azurewei@chromium.org, Aug 30 2016

Labels: Merge-Request-54

Comment 8 by dimu@chromium.org, Aug 30 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b7861363f6516a8f081c146568e9d767b73a09

commit 31b7861363f6516a8f081c146568e9d767b73a09
Author: azurewei <azurewei@chromium.org>
Date: Tue Aug 30 03:55:54 2016

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )"

This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac.

Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production.

Fix the underlying crash problem and add new test:
ImeMenuTrayTest.QuitChromeWithMenuOpen
to cover it.

TBR=jamescook@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 640432 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2277753006
Cr-Commit-Position: refs/heads/master@{#414819}
(cherry picked from commit c6200ab48ee282cae1460dfd1aaeafbf732897d6)

Review-Url: https://codereview.chromium.org/2288823004
Cr-Commit-Position: refs/branch-heads/2840@{#30}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/test/test_system_tray_delegate.h

Comment 10 by msrchandra@chromium.org, Sep 1 2016

Cc: msrchandra@chromium.org
Labels: Needs-Feedback
@zhangyu -- Checked for the Flag in Linux 14.04, but is not available. Could you please provide us steps to verify the issue on Linux from TE side.
Thanks in Advance.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b7861363f6516a8f081c146568e9d767b73a09

commit 31b7861363f6516a8f081c146568e9d767b73a09
Author: azurewei <azurewei@chromium.org>
Date: Tue Aug 30 03:55:54 2016

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )"

This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac.

Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production.

Fix the underlying crash problem and add new test:
ImeMenuTrayTest.QuitChromeWithMenuOpen
to cover it.

TBR=jamescook@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 640432 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2277753006
Cr-Commit-Position: refs/heads/master@{#414819}
(cherry picked from commit c6200ab48ee282cae1460dfd1aaeafbf732897d6)

Review-Url: https://codereview.chromium.org/2288823004
Cr-Commit-Position: refs/branch-heads/2840@{#30}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/31b7861363f6516a8f081c146568e9d767b73a09/ash/test/test_system_tray_delegate.h
►

Sign in to add a comment