^^^
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bb5bcc3e855e57293999433cab3a1cb8971597b commit 8bb5bcc3e855e57293999433cab3a1cb8971597b Author: rouslan <rouslan@chromium.org> Date: Tue Aug 30 05:18:32 2016 Separate credit card scanner from native bridge. This patch enables using credit card scanner directly from Java, without jumping to native first. Checking of the "AutofillScanCardholderName" flag has moved into the Java delegate wrapper, so users of this functionality in Java are governed by the same flag, regardless of the implementation. BUG= 640430 Review-Url: https://codereview.chromium.org/2274693004 Cr-Commit-Position: refs/heads/master@{#415146} [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CreditCardScanner.java [add] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CreditCardScannerBridge.java [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/android/java_sources.gni [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc [modify] https://crrev.com/8bb5bcc3e855e57293999433cab3a1cb8971597b/chrome/chrome_browser.gypi
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/e90dd31dbe6a0236cdca259d6e39716acd7293b6 commit e90dd31dbe6a0236cdca259d6e39716acd7293b6 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Mon Aug 29 18:30:22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8 commit 2cd2a4761a56c717f297184c3b6c65a2ee9e03c8 Author: rouslan <rouslan@chromium.org> Date: Fri Sep 09 21:06:50 2016 Add credit card scanner to payments UI. The credit card scanner UI is behind the chrome://flags#scan-cards-in-web-payments flag until UI behavior is polished. BUG= 640430 Review-Url: https://codereview.chromium.org/2286563002 Cr-Commit-Position: refs/heads/master@{#417709} [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [rename] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldView.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/android/java_sources.gni [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/app/generated_resources.grd [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/browser/about_flags.cc [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/components/autofill_strings.grdp [modify] https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8/tools/metrics/histograms/histograms.xml
Assigning to Dan to polish the UI experience. The flag can be removed when the UI is polished.
gogerald@ is working on this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3da4b51497fca50ebed5e4adbec3f7ada68ceda commit c3da4b51497fca50ebed5e4adbec3f7ada68ceda Author: gogerald <gogerald@chromium.org> Date: Tue Oct 25 01:37:21 2016 Float card scanner icon at the end of EditText instead of compound drawable This gives better user experience since compound drawable do not support click event. BUG= 657178 , 640430 Review-Url: https://codereview.chromium.org/2434383002 Cr-Commit-Position: refs/heads/master@{#427222} [modify] https://crrev.com/c3da4b51497fca50ebed5e4adbec3f7ada68ceda/chrome/android/java/res/layout/payments_request_editor_textview.xml [modify] https://crrev.com/c3da4b51497fca50ebed5e4adbec3f7ada68ceda/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9 commit ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9 Author: gogerald <gogerald@chromium.org> Date: Mon Oct 31 18:48:07 2016 Remove credit scan scanner experimental flag BUG= 640430 Review-Url: https://codereview.chromium.org/2452243002 Cr-Commit-Position: refs/heads/master@{#428761} [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/app/generated_resources.grd [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/browser/about_flags.cc [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9/chrome/browser/android/chrome_feature_list.h
Verified in M56-56.0.2906.0 build, now no flag needed to scan creditcard
Would like to merge https://crrev.com/c3da4b51497fca50ebed5e4adbec3f7ada68ceda and https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9 to M-55.
Your change meets the bar and is auto-approved for M55 (branch: 2883)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce76404e0039ea48174770ecfc09e356aed8bd1b commit ce76404e0039ea48174770ecfc09e356aed8bd1b Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 01 22:01:12 2016 [Merge M-55] Float card scanner icon at the end of EditText instead of compound drawable This gives better user experience since compound drawable do not support click event. BUG= 657178 , 640430 Review-Url: https://codereview.chromium.org/2434383002 Cr-Commit-Position: refs/heads/master@{#427222} (cherry picked from commit c3da4b51497fca50ebed5e4adbec3f7ada68ceda) Review URL: https://codereview.chromium.org/2474493002 . Cr-Commit-Position: refs/branch-heads/2883@{#410} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ce76404e0039ea48174770ecfc09e356aed8bd1b/chrome/android/java/res/layout/payments_request_editor_textview.xml [modify] https://crrev.com/ce76404e0039ea48174770ecfc09e356aed8bd1b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e commit 11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 01 22:09:20 2016 [Merge M-55] Remove credit scan scanner experimental flag BUG= 640430 Review-Url: https://codereview.chromium.org/2452243002 Cr-Commit-Position: refs/heads/master@{#428761} (cherry picked from commit ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9) Review URL: https://codereview.chromium.org/2469953002 . Cr-Commit-Position: refs/branch-heads/2883@{#411} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/app/generated_resources.grd [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/browser/about_flags.cc [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/11b433cf43e6e6e2f5f8a0ec3deda4b0a441e50e/chrome/browser/android/chrome_feature_list.h
Verified in M55-55.0.2883.36 build
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a678f0724e1b28964f71f489572e63f33b16efc7 commit a678f0724e1b28964f71f489572e63f33b16efc7 Author: gogerald <gogerald@google.com> Date: Fri Aug 25 13:15:27 2017 [Payments] Fix format inconsistency from scanner Bug: 640430 Change-Id: I6caf0ed8aab925de43261c3a0412cc3489c853e8 Reviewed-on: https://chromium-review.googlesource.com/634219 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#497388} [modify] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016