New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640427 link

Starred by 1 user
Status: Verified
Owner:
azurewei@chromium.org
Closed: Aug 2016
Cc:
shuchen@chromium.org
█ xiangye@chromium.org
wuyingbing@chromium.org
xiulingw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Opt-in IME menu has not been set with max height.

Project Member Reported by azurewei@chromium.org, Aug 24 2016 
OS: ChromeOS

What steps will reproduce the problem?
(1) Enable the flag "Enable opt-in IME menu" in about://flags page.
(2) Open "language and input" settings page, check the box with label "Show input options in the shelf".
(3) Keep selecting IMEs

What is the expected output?

Opt-in IME menu has a max height and then show scroll-able content.

What do you see instead?

The height of the menu keeps rising.
Screenshot.png
49.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee46213fbcad7272d5b9c9d7a6492598239c2f1

commit 5ee46213fbcad7272d5b9c9d7a6492598239c2f1
Author: azurewei <azurewei@chromium.org>
Date: Wed Aug 24 00:49:36 2016

Sets the max height of ImeMenuTray.

The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most.

BUG= 640427 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2254453002
Cr-Commit-Position: refs/heads/master@{#413912}

[modify] https://crrev.com/5ee46213fbcad7272d5b9c9d7a6492598239c2f1/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/5ee46213fbcad7272d5b9c9d7a6492598239c2f1/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Comment 2 by azurewei@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)

Comment 3 by zhan...@chromium.org, Aug 25 2016

Cc: wuyingbing@chromium.org shuchen@chromium.org xiangye@chromium.org xiulingw@chromium.org
Components: UI>Input>Text>IME
Labels: InputTools-54 M-54
Status: Assigned (was: Fixed)
Check in M54.0.2837.0 platform 8738.0.0 clapper ,

If checked "Autohide shelf" in right-click shelf menu, this issue still repro

Comment 4 by azurewei@chromium.org, Aug 27 2016

Status: Fixed (was: Assigned)

Comment 5 by zhan...@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
Verified in M55-8749 clapper

Comment 6 by azurewei@chromium.org, Aug 30 2016

Labels: Merge-Request-54

Comment 7 by dimu@chromium.org, Aug 30 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Commit may have occurred before M54 branch point (8/25/2016), needs manual review.

Comment 8 by josa...@google.com, Sep 8 2016

Labels: -Merge-Review-54 Merge-Approved-54
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 11 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by shuchen@chromium.org, Sep 11 2016

Labels: -Merge-Approved-54 Merge-Merged

Comment 11 by shuchen@chromium.org, Sep 11 2016

Labels: -Merge-Merged Merge-Approved-54
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 14 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by azurewei@chromium.org, Sep 14 2016

Labels: -Merge-Approved-54

Comment 14 by azurewei@chromium.org, Sep 14 2016

Labels: -Hotlist-Merge-review
►

Sign in to add a comment