New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640422 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Aug 2016
Cc:
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

'Sign in to chrome' button styling incorrect

Project Member Reported by bettes@chromium.org, Aug 24 2016 
Font weight doesn't seem right and the inner-padding looks too small 

Expected: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_buttons.png%3Fz=width
Screen Shot 2016-08-23 at 5.08.13 PM.png
110 KB View Download
Screen Shot 2016-08-23 at 5.05.11 PM.png
39.0 KB View Download

Comment 1 by tsergeant@chromium.org, Aug 24 2016

Status: Started (was: Assigned)
I've increased the padding and changed the font to 13px Roboto Medium.
fAKyh4XHcQK.png
22.6 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c

commit a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Aug 24 05:08:50 2016

MD History: Tweak appearance of sign-in promotion

This changes the style of the sign-in button to better match the mocks,
and changes font-sizes across the page to percentage-based, so they can
resize according to user preferences.

BUG= 640422 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2269423002
Cr-Commit-Position: refs/heads/master@{#413983}

[modify] https://crrev.com/a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c/chrome/browser/resources/md_history/synced_device_manager.html

Comment 3 by tsergeant@chromium.org, Aug 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment