New issue
Advanced search Search tips

Issue 640384 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640365



Sign in to add a comment

Implement ImmersiveModeControllerAsh::Observe for mash

Project Member Reported by sky@chromium.org, Aug 23 2016

Issue description

This toggles some state in WindowState, which isn't available in mash. It may be this should just sets fullscreen on the window and ash will pick it up correctly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/614a167430f1d98750f07116c945238103ad861e

commit 614a167430f1d98750f07116c945238103ad861e
Author: Elliot Glaysher <erg@chromium.org>
Date: Mon Nov 27 21:12:21 2017

[mash] Use an aura::Window property for hide shelf in fullscreen mode.

This removes another direct usage of ash::wm::WindowState from
//chrome/. It also reworks the signaling mechanism in
ImmersiveModeControllerAsh so that on fullscreen change events, we
correctly update the shelf visibility without directly linking with
ash code.

Bug: 780160,  640384 
Change-Id: I0539d37639974f0c170306dc1dcbcd26389faf97
Reviewed-on: https://chromium-review.googlesource.com/758974
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519403}
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/cpp/window_properties.h
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/session/session_controller.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/system/web_notification/fullscreen_notification_blocker.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/immersive_context_ash.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/window_state.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/window_state.h
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/components/exo/shell_surface.cc

Comment 2 by e...@chromium.org, Dec 6 2017

Status: Fixed (was: Untriaged)
Status: Archived (was: Fixed)

Sign in to add a comment