New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640381 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640365



Sign in to add a comment

Get ImmersiveModeControllerAsh::OnPostWindowStateTypeChange working for mash

Project Member Reported by sky@chromium.org, Aug 23 2016

Issue description

It won't ever be called in mash. This bug is to figure if it's needed, and if so wire up it correctly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331bfdfc79d5ff8fc244190c12cac0fdbc0eee70

commit 331bfdfc79d5ff8fc244190c12cac0fdbc0eee70
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Sep 27 17:22:29 2017

[ash] Make chrome's immersive mode watch properties.

Instead of implementing an ash specific observer type, watch shared
properties on the aura::Window instead. This removes dependence on
non-public ash types, and simplifies all three ashs (classic,mus,mash)
so they go through the same code path.

Bug:  640381 
Change-Id: I1837202ae3fadd177c2a54b31d6cc31ed974b621
Test: ImmersiveModeControllerAshTest.*, Manual in all 3 configurations
Reviewed-on: https://chromium-review.googlesource.com/685538
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504716}
[modify] https://crrev.com/331bfdfc79d5ff8fc244190c12cac0fdbc0eee70/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/331bfdfc79d5ff8fc244190c12cac0fdbc0eee70/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

Comment 2 by e...@chromium.org, Sep 28 2017

Owner: e...@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment