New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Ctrl+E shortcut does not work in timeline.

Project Member Reported by alph@chromium.org, Aug 23 2016

Issue description

It gets handled by the debugger.evaluate-selection action.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2082aee94be65ebdcc86e5b6e667537564ac837b

commit 2082aee94be65ebdcc86e5b6e667537564ac837b
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Sep 06 23:07:22 2016

Revert of DevTools: remove UISourceCodeFrame from context when switching panels. (patchset #2 id:20001 of https://codereview.chromium.org/2287713002/ )

Reason for revert:
I'll have a better one for merge.

Original issue's description:
> DevTools: remove UISourceCodeFrame from context when switching panels.
>
> BUG= 640375 
>
> Committed: https://crrev.com/0cfac8a68fbabad4515c0a9f58c9e1dffd8c4a74
> Cr-Commit-Position: refs/heads/master@{#415105}

TBR=alph@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 640375 

Review-Url: https://codereview.chromium.org/2311303002
Cr-Commit-Position: refs/heads/master@{#416753}

[modify] https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b/third_party/WebKit/Source/devtools/front_end/ui/Context.js

Labels: Merge-Request-54
Status: Started (was: Assigned)

Comment 5 by dimu@chromium.org, Sep 14 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) so that we could take this for next Beta Release.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 18 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Gentle ping for merging.

Please merge your change to M54 (branch: 2840) before 4.00 PM PST by Tuesday ( 09/20) so that we could take this for next Beta Release.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1339ab8e8254ab8264805bcb9ac367b5254e9ff4

commit 1339ab8e8254ab8264805bcb9ac367b5254e9ff4
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Sep 19 21:21:31 2016

DevTools: remove UISourceCodeFrame from context when switching panels.

BUG= 640375 

Review-Url: https://codereview.chromium.org/2314503005
Cr-Commit-Position: refs/heads/master@{#417120}
(cherry picked from commit 0256fbaededb2fd7db51f5559d9656ceebc3e736)

Review URL: https://codereview.chromium.org/2354733002 .

Cr-Commit-Position: refs/branch-heads/2840@{#421}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/ui/Context.js

Cc: msrchandra@chromium.org
Labels: Needs-Feedback
@alph -- Could you please provide us steps to verify the issue which would help us verify the issue.
As per my observation clicking on Ctrl + E is highlighting Omnibox giving as option "Search Google".

Thank You.
Not holding Beta Release for today, we will verify once the steps are available.

Comment 12 by alph@chromium.org, Sep 22 2016

To reproduce, open DevTools for a page. Click Sources panel. Click Timeline panel. Press Ctrl+E. Recording should start if it works ok.
Labels: -Needs-Feedback TE-Verified-54.0.2840.34 TE-Verified-M54
Tested the issue on Chrome Beta# 54.0.2840.34 on Windows, Mac and Linux and is working as intended. Hence adding TE-Verified labels.
Attaching the screencast for reference.
Thank You.
640375.mov
4.0 MB Download
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1339ab8e8254ab8264805bcb9ac367b5254e9ff4

commit 1339ab8e8254ab8264805bcb9ac367b5254e9ff4
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Sep 19 21:21:31 2016

DevTools: remove UISourceCodeFrame from context when switching panels.

BUG= 640375 

Review-Url: https://codereview.chromium.org/2314503005
Cr-Commit-Position: refs/heads/master@{#417120}
(cherry picked from commit 0256fbaededb2fd7db51f5559d9656ceebc3e736)

Review URL: https://codereview.chromium.org/2354733002 .

Cr-Commit-Position: refs/branch-heads/2840@{#421}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/1339ab8e8254ab8264805bcb9ac367b5254e9ff4/third_party/WebKit/Source/devtools/front_end/ui/Context.js

Status: Fixed (was: Started)

Sign in to add a comment