New issue
Advanced search Search tips

Issue 640374 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640365



Sign in to add a comment

Implement ImmersiveContext::IsMouseEventsEnabled() in chrome

Project Member Reported by sky@chromium.org, Aug 23 2016

Issue description

See ImmersiveContextMus. Chrome will likely need to cache this state from either mash or mus.
 

Comment 1 by e...@chromium.org, Nov 28 2017

Owner: e...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by e...@chromium.org, Mar 6 2018

Owner: ----
Status: Available (was: Assigned)
Mass unassigning bugs
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3fa200760daad23aedfea73cc079edcd927205c

commit b3fa200760daad23aedfea73cc079edcd927205c
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 06 18:00:16 2018

Refactor ImmersiveGestureHandler to work in Mash.

Currently, ImmersiveGestureHandlerClassic installs itself as a pretarget
handler on Shell. This is necessary to get events from bezel sensors,
which have bounds outside the immersive fs window. It also forwards
gesture events to ImmersiveFullscreenController.

Keep the part of ImmersiveGestureHandlerClassic that handles drag-
triggering gesture events in tablet mode (i.e. most of the class) and
run that within Ash in both Classic and Mash configurations.

Make ImmersiveFullscreenController a pretarget handler for the toplevel
window when it's in immersive mode. This works in either Ash or client
as ImmersiveFullscreenController doesn't need to get events outside of
the window's bounds. ImmersiveFullscreenController is now both an
EventHandler (for gesture events) and an EventObserver (for mouse and
touch events).

Bug:  624157 ,640374
Change-Id: I83536cb407b4ac890db63d4c6a0fe98b7912a3f4
Reviewed-on: https://chromium-review.googlesource.com/c/1300678
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605733}
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/BUILD.gn
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/public/cpp/immersive/immersive_context.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/public/cpp/immersive/immersive_fullscreen_controller.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/public/cpp/immersive/immersive_fullscreen_controller.h
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/public/cpp/immersive/immersive_gesture_handler.h
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/public/cpp/immersive/immersive_handler_factory.cc
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/public/cpp/immersive/immersive_handler_factory.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/shell.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/shell.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/immersive_context_ash.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/immersive_context_ash.h
[rename] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/immersive_gesture_drag_handler.cc
[add] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/immersive_gesture_drag_handler.h
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/wm/immersive_gesture_handler_classic.h
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/wm/immersive_handler_factory_ash.cc
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/ash/wm/immersive_handler_factory_ash.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/window_state.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/ash/wm/window_state.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/chrome/browser/ui/views/frame/immersive_context_mus.cc
[modify] https://crrev.com/b3fa200760daad23aedfea73cc079edcd927205c/chrome/browser/ui/views/frame/immersive_context_mus.h
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/chrome/browser/ui/views/frame/immersive_handler_factory_mus.cc
[delete] https://crrev.com/04ffe015fad5fa68bc571938d1aa06c955d34812/chrome/browser/ui/views/frame/immersive_handler_factory_mus.h

Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment