New issue
Advanced search Search tips

Issue 640371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640365



Sign in to add a comment

Implement OnEnteringOrExitingImmersive for chrome

Project Member Reported by sky@chromium.org, Aug 23 2016

Issue description

See the implementation in ImmersiveContextAsh for details on what this should do. I'm tagging this with both chrome and mash as both sides likely need some amount of changes.
 

Comment 1 by sky@chromium.org, Aug 23 2016

Blocking: 640365
Components: MUS
Labels: Proj-Mustash
Components: Internals>MUS
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62508586d4d61e4cad72cfe985413708e90c6969

commit 62508586d4d61e4cad72cfe985413708e90c6969
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Nov 29 19:18:17 2017

Implement ImmersiveContextMus::OnEnteringOrExitingImmersive().

This changes ash::WindowState to use the aura::Window property that
tracks the same thing instead of storing its own state which gets
updated from the Window.

Bug:  640371 
Change-Id: Ia7d3744844fc21a5f437ecd5376d839933b50c65
Reviewed-on: https://chromium-review.googlesource.com/794831
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520188}
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/immersive_context_ash.cc
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/tablet_mode/tablet_mode_event_handler.cc
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/window_state.cc
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/ash/wm/window_state.h
[modify] https://crrev.com/62508586d4d61e4cad72cfe985413708e90c6969/chrome/browser/ui/views/frame/immersive_context_mus.cc

Comment 6 by e...@chromium.org, Nov 29 2017

Status: Fixed (was: Untriaged)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment