New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK fails shared_state_.renderer when deselecting video track and backgrounding a video

Project Member Reported by avayvod@chromium.org, Aug 23 2016

Issue description

Chrome 54 (tot) Debug build.

1. Enable experimental WebGL features
2. Open a page that deselects the video track if backgrounded (like http://avayvod.github.io/demo.html).
3. Play a video (for instance, select Sintel 4K in the dropdown and click Load, then on the play icon).
4. Press the Home button to background Chrome

ER: Chrome doesn't crash, user is able to resume the video from the notification
AR: Chrome crashes with the DCHECK in pipeline_impl.cc(605), notification disappears.
 
Labels: -Pri-3 Pri-2
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f450aa795c85f615ccaed457f3114c487df7ac4

commit 5f450aa795c85f615ccaed457f3114c487df7ac4
Author: servolk <servolk@chromium.org>
Date: Thu Sep 01 23:53:38 2016

Fix DCHECK when track status changes in non-playing state

We are only accessing shared_state_.renderer in kPlaying state.

BUG= 640362 

Review-Url: https://codereview.chromium.org/2269313002
Cr-Commit-Position: refs/heads/master@{#416131}

[modify] https://crrev.com/5f450aa795c85f615ccaed457f3114c487df7ac4/media/base/pipeline_impl.cc
[modify] https://crrev.com/5f450aa795c85f615ccaed457f3114c487df7ac4/media/renderers/renderer_impl.cc
[modify] https://crrev.com/5f450aa795c85f615ccaed457f3114c487df7ac4/media/test/pipeline_integration_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee58ec4c8b347db61fcd346ca293c6893cc1ec87

commit ee58ec4c8b347db61fcd346ca293c6893cc1ec87
Author: servolk <servolk@chromium.org>
Date: Fri Sep 02 18:56:52 2016

Revert of Fix DCHECK when track status changes in non-playing state (patchset #3 id:40001 of https://codereview.chromium.org/2269313002/ )

Reason for revert:
The new test is crashing on Mac

Original issue's description:
> Fix DCHECK when track status changes in non-playing state
>
> We are only accessing shared_state_.renderer in kPlaying state.
>
> BUG= 640362 
>
> Committed: https://crrev.com/5f450aa795c85f615ccaed457f3114c487df7ac4
> Cr-Commit-Position: refs/heads/master@{#416131}

TBR=avayvod@chromium.org,chcunningham@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 640362 

Review-Url: https://codereview.chromium.org/2310483002
Cr-Commit-Position: refs/heads/master@{#416309}

[modify] https://crrev.com/ee58ec4c8b347db61fcd346ca293c6893cc1ec87/media/base/pipeline_impl.cc
[modify] https://crrev.com/ee58ec4c8b347db61fcd346ca293c6893cc1ec87/media/renderers/renderer_impl.cc
[modify] https://crrev.com/ee58ec4c8b347db61fcd346ca293c6893cc1ec87/media/test/pipeline_integration_test.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ed890b572504e099b9e974c29c69d168881a6a

commit 09ed890b572504e099b9e974c29c69d168881a6a
Author: servolk <servolk@chromium.org>
Date: Wed Sep 28 22:46:28 2016

Fix DCHECK when track status changes in non-playing state

Reland of https://codereview.chromium.org/2269313002
That CL added a new unit test TrackStatusChangesWhileSuspended that
turned out to be flaky. I have investigated the flakiness and tracked
it down to a race condition in Renderer destruction when pipeline is
being suspended. That race condition has been recently fixed (see
https://codereview.chromium.org/2355173002 and crbug.com/638018) and
the new test is not flaky anymore. I've confirmed that the test becomes
flaky again when I revert commit bdf51ba921ccbc locally.

BUG= 640362 

Review-Url: https://codereview.chromium.org/2378893002
Cr-Commit-Position: refs/heads/master@{#421669}

[modify] https://crrev.com/09ed890b572504e099b9e974c29c69d168881a6a/media/base/pipeline_impl.cc
[modify] https://crrev.com/09ed890b572504e099b9e974c29c69d168881a6a/media/renderers/renderer_impl.cc
[modify] https://crrev.com/09ed890b572504e099b9e974c29c69d168881a6a/media/test/pipeline_integration_test.cc

Labels: VideoTrackHotlist
Status: Fixed (was: Started)
Closing as Fixed per comment #4.

Sign in to add a comment