New issue
Advanced search Search tips

Issue 640357 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

43.1% improvement in browser_tests at 413690:413695

Project Member Reported by peah@chromium.org, Aug 23 2016

Issue description

These regressions have the most likely causing CLs:
https://codereview.webrtc.org/2262683002
https://codereview.webrtc.org/2223033002

nisser@: Could you please first have a look and pass it on to holmer@ if you don't think that your CL caused the issue!
 

Comment 1 by peah@chromium.org, Aug 23 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=640357

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg3snfogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg3u60vQkM


Bot(s) for this bug's original alert(s):

chromium-webrtc-rel-mac

Comment 2 by nisse@chromium.org, Sep 13 2016

Hmm, not quite "back to normal", needs investigation.

Comment 3 by peah@chromium.org, Oct 21 2016

Any updates on this? Can it be closed?

Comment 4 by nisse@chromium.org, Oct 21 2016

Owner: holmer@chromium.org
Hmm, can probably be closed.

Where were some jumps in these graphs due to a broken cl of mine which was reverted. Graphs show a small improvement compared to before those changes, but it seems hard to identify the corresponding change in the code.

My cl in the alert looks very unrelated. holmer@, do you want to have a another look before closing?

Comment 5 by holmer@chromium.org, Nov 17 2016

Cc: holmer@chromium.org
Owner: nisse@chromium.org
If anything it looks like the issue introduced in https://bugs.chromium.org/p/chromium/issues/detail?id=639751 never fully recovered?

An improvement like the one tracked here seems less useful to dig into.

Nisse, I'll leave it to you to close if you think this is worth keeping open.

Comment 6 by nisse@chromium.org, Nov 17 2016

Status: WontFix (was: Assigned)
There are a lot of graphs. I've had another look, and for the other issue (https://bugs.chromium.org/p/chromium/issues/detail?id=639751) everything seems back to normal to me. And graphs for this issue show a small improvement after the dust settled. I don't plan to spend time on investigating, so I'm closing.

Sign in to add a comment