New issue
Advanced search Search tips

Issue 640354 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add a --json option to git cl try-results

Project Member Reported by qyears...@chromium.org, Aug 23 2016

Issue description

This would make it simpler to decide which try jobs to start in webkit-patch rebaseline-cl, and would also allow me to simplify https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py, which currently parses the human-readable git cl try-results output.

This was suggested in  http://crbug.com/639533#c2 .
 
LGTM! Don't parse human readable results.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/53f48a1c52f7d35daa160894585dffe8aafe231d

commit 53f48a1c52f7d35daa160894585dffe8aafe231d
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Sep 01 17:45:13 2016

Add a --json option to git cl try-results.

For use in scripts that check try job results, this is
currently practically the same as making requests to
https://codereview.chromium.org/api/<cl-number>/<patchset-number>.

However, I think that this might be more future-proof, since
it fetches try job information from Buildbucket, and I expect
to still work after migration from Rietveld to Gerrit.

BUG= 640354 

Review-Url: https://codereview.chromium.org/2274743003

[modify] https://crrev.com/53f48a1c52f7d35daa160894585dffe8aafe231d/git_cl.py
[modify] https://crrev.com/53f48a1c52f7d35daa160894585dffe8aafe231d/tests/git_cl_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e41beffc6b6aae58d4af0c7a7a6cc46696674d05

commit e41beffc6b6aae58d4af0c7a7a6cc46696674d05
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 01 17:54:14 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/53f48a1c52f7d35daa160894585dffe8aafe231d Add a --json option to git cl try-results. (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 640354 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2305713002

[modify] https://crrev.com/e41beffc6b6aae58d4af0c7a7a6cc46696674d05/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/787a83d48145cb79880a1892066c930a48e3609f

commit 787a83d48145cb79880a1892066c930a48e3609f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 01 18:24:27 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e41beffc6b6aae58d4af0c7a7a6cc46696674d05 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/53f48a1c52f7d35daa160894585dffe8aafe231d Add a --json option to git cl try-results. (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 640354 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2294913008

[modify] https://crrev.com/787a83d48145cb79880a1892066c930a48e3609f/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8af041b8f6af961b4041cbd6f5485a16ffeda30

commit f8af041b8f6af961b4041cbd6f5485a16ffeda30
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 01 18:30:18 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e41beffc6b6aae58d4af0c7a7a6cc46696674d05 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/53f48a1c52f7d35daa160894585dffe8aafe231d Add a --json option to git cl try-results. (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 640354 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299023005
Cr-Commit-Position: refs/heads/master@{#416002}

[modify] https://crrev.com/f8af041b8f6af961b4041cbd6f5485a16ffeda30/infra/config/recipes.cfg

Status: Fixed (was: Started)

Sign in to add a comment