New issue
Advanced search Search tips

Issue 640353 link

Starred by 1 user
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Sep 2016
Cc:
rsesek@chromium.org
erikc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac dictionary (Ctrl+Command+D) has incorrect location when content is inside <iframe>.

Project Member Reported by ekaramad@chromium.org, Aug 23 2016 
Version: 52.0.2743.116 (Official Build) (64-bit)
OS: Mac OSX El Capitan 10.11.6

What steps will reproduce the problem?
(1) Open a page with an <iframe> containing some text.
(2) Hover over a word.
(3) Press Ctrl + Command + D.

What is the expected output?
The dictionary window show appear close to where the word is.

What do you see instead?
The dictionary appears way below the screen but the x-axis seems correct.

This bug seems to have existed from long before the reported version. Did not find
repro_steps_mac_dictionary_bug.mov
3.2 MB Download

Comment 1 by karandeepb@chromium.org, Aug 24 2016

Labels: -Pri-2 Pri-3
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Assigning to rsesek@ who implemented the system dictionary popup.

Comment 2 by ranjitkan@chromium.org, Aug 24 2016

Components: UI

Comment 3 by ekaramad@chromium.org, Aug 25 2016

Cc: rsesek@chromium.org
Owner: ekaramad@chromium.org
Status: Started (was: Assigned)
I poked at it and have an ongoing CL. I will reassign it to myself.
On going CL: https://codereview.chromium.org/2275323003/.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7f50ad0c94d0c134c3b6e975c5b217ac4ace30

commit cf7f50ad0c94d0c134c3b6e975c5b217ac4ace30
Author: ekaramad <ekaramad@chromium.org>
Date: Fri Aug 26 21:35:23 2016

Fix position of dictionary pop-up for <iframe>.

In blink, we convert the string position to root frame and then convert to
AppKit coordinates by inverting y-axis. To do so, we must always use
FrameView::height() of the root frame rather than that of the
LocalFrame.

BUG= 640353 

Review-Url: https://codereview.chromium.org/2275323003
Cr-Commit-Position: refs/heads/master@{#414814}

[modify] https://crrev.com/cf7f50ad0c94d0c134c3b6e975c5b217ac4ace30/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
[modify] https://crrev.com/cf7f50ad0c94d0c134c3b6e975c5b217ac4ace30/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Comment 5 by ekaramad@chromium.org, Sep 14 2016

Status: Fixed (was: Started)
Marking as fixed since I verified it on Canary 55.0.2860.0 #418438.
►

Sign in to add a comment