New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640330 link

Starred by 1 user
Status: Verified
Owner:
r...@chromium.org
Closed: Aug 2016
Cc:
█ hirono@chromium.org
█ lhchavez@chromium.org
xiy...@chromium.org
abodenha@chromium.org
rdevlin....@chromium.org
satorux@chromium.org
tbarzic@chromium.org
michae...@chromium.org
█ zelidrag@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 624113



Sign in to add a comment

Provide play store capability info to specific launched apps.

Project Member Reported by r...@chromium.org, Aug 23 2016 
Currently the Chrome OS demo app and the GetHelp app need to know whether,

a.) The device they are running on can run ARC++
b.) If ARC++ is enabled on the device

This will allow these apps to make decision about their content. Since we launch these apps from within Chrome OS, we should provide additional fields in the launch parameters of onLaunched (https://developer.chrome.com/apps/app_runtime#event-onLaunched).


This is the cleanest way to do so since it avoids any need for whitelisting. An app that we launch as the demo app, or as the GetHelp app, will have these values at launch.

Comment 1 by r...@chromium.org, Aug 23 2016

Labels: -M-53 M-54

Comment 2 by r...@chromium.org, Aug 24 2016

Blocking: 624113

Comment 3 by st...@chromium.org, Aug 24 2016

Owner: st...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d97de469a486debcb8956de8f7ed679fa862cbf

commit 3d97de469a486debcb8956de8f7ed679fa862cbf
Author: rkc <rkc@chromium.org>
Date: Thu Aug 25 07:06:00 2016

Add ARC++ specific fields to launch data for specific apps.

On devices that have ARC++ available or enabled, certain internal apps need
to be able to get this information. Currently these are limited to the
GetHelp and the demo app.

These are fields we'd like to eventually just expose to all apps but currently
security is not comfortable with that yet, so for now, we'll set these flags
only for the apps that currently need it.

Reviews requested,
xiyuan@ - General review.
asargent@ - //apps and extension parts
lhchavez@ - ARC++ parts
sky@ - //chrome/browser/ui

R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
BUG= 640330 

Review-Url: https://codereview.chromium.org/2272813003
Cr-Commit-Position: refs/heads/master@{#414348}

[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/apps/launcher.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/apps/launcher.h
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/apps/app_launch_for_metro_restart_win.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/ui/extensions/app_launch_params.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/ui/extensions/app_launch_params.h
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/components/arc/arc_bridge_service.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/components/arc/arc_bridge_service.h
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/extensions/browser/api/app_runtime/app_runtime_api.h
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/extensions/common/api/app_runtime.idl
[modify] https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf/extensions/shell/browser/shell_extension_system.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd6f574540628307c652b24895e32c903ebf3c2

commit ffd6f574540628307c652b24895e32c903ebf3c2
Author: haraken <haraken@chromium.org>
Date: Thu Aug 25 07:47:42 2016

Revert of Add ARC++ specific fields to launch data for specific apps. (patchset #7 id:120001 of https://codereview.chromium.org/2272813003/ )

Reason for revert:
This broke compilation of ChromeOS:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/22483

Original issue's description:
> Add ARC++ specific fields to launch data for specific apps.
>
> On devices that have ARC++ available or enabled, certain internal apps need
> to be able to get this information. Currently these are limited to the
> GetHelp and the demo app.
>
> These are fields we'd like to eventually just expose to all apps but currently
> security is not comfortable with that yet, so for now, we'll set these flags
> only for the apps that currently need it.
>
> Reviews requested,
> xiyuan@ - General review.
> asargent@ - //apps and extension parts
> lhchavez@ - ARC++ parts
> sky@ - //chrome/browser/ui
>
> R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
> BUG= 640330 
>
> Committed: https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf
> Cr-Commit-Position: refs/heads/master@{#414348}

TBR=asargent@chromium.org,lhchavez@chromium.org,sky@chromium.org,xiyuan@chromium.org,rkc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 640330 

Review-Url: https://codereview.chromium.org/2276293002
Cr-Commit-Position: refs/heads/master@{#414351}

[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/apps/launcher.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/apps/launcher.h
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/apps/app_launch_for_metro_restart_win.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/ui/extensions/app_launch_params.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/ui/extensions/app_launch_params.h
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/components/arc/arc_bridge_service.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/components/arc/arc_bridge_service.h
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/extensions/browser/api/app_runtime/app_runtime_api.h
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/extensions/common/api/app_runtime.idl
[modify] https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2/extensions/shell/browser/shell_extension_system.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79bf63cbe7a00345f152d0dbb3dc20e24442713f

commit 79bf63cbe7a00345f152d0dbb3dc20e24442713f
Author: rkc <rkc@chromium.org>
Date: Thu Aug 25 21:07:23 2016

Add ARC++ specific fields to launch data for specific apps.

On devices that have ARC++ available or enabled, certain internal apps need
to be able to get this information. Currently these are limited to the
GetHelp and the demo app.

These are fields we'd like to eventually just expose to all apps but currently
security is not comfortable with that yet, so for now, we'll set these flags
only for the apps that currently need it.

Reviews requested,
xiyuan@ - General review.
asargent@ - //apps and extension parts
lhchavez@ - ARC++ parts
sky@ - //chrome/browser/ui

R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
BUG= 640330 

Committed: https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf
Review-Url: https://codereview.chromium.org/2272813003
Cr-Original-Commit-Position: refs/heads/master@{#414348}
Cr-Commit-Position: refs/heads/master@{#414535}

[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/apps/launcher.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/apps/launcher.h
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/apps/app_launch_for_metro_restart_win.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/ui/extensions/app_launch_params.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/ui/extensions/app_launch_params.h
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/components/arc/arc_bridge_service.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/components/arc/arc_bridge_service.h
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/extensions/browser/api/app_runtime/app_runtime_api.h
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/extensions/common/api/app_runtime.idl
[modify] https://crrev.com/79bf63cbe7a00345f152d0dbb3dc20e24442713f/extensions/shell/browser/shell_extension_system.cc

Comment 7 by st...@chromium.org, Aug 25 2016

Status: Fixed (was: Started)

Comment 8 by dhadd...@chromium.org, Oct 21 2016

Status: Verified (was: Fixed)
GetHelp talks about Android apps on Samus

Comment 9 by st...@chromium.org, Mar 3 2017

Owner: r...@chromium.org
►

Sign in to add a comment