New issue
Advanced search Search tips

Issue 640323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 630505



Sign in to add a comment

MD Settings: Subpage back button goes forward a subpage

Project Member Reported by michae...@chromium.org, Aug 23 2016

Issue description

1. Load chrome://md-settings/siteSettings/camera
2. Press subpage back button, which goes to /siteSettings
3. Press subpage back button

Expected: chrome://md-settings
Actual: chrome://md-settings/siteSettings/camera
 
Blocking: 630505
Components: UI>Settings
Labels: -Pri-3 Proj-MaterialDesign-WebUI OS-All Pri-2
Owner: tommycli@chromium.org
Status: Assigned (was: ass)
Oh. fml
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e988531f70d2489982275e0fc26e18f8cc6c9ca

commit 3e988531f70d2489982275e0fc26e18f8cc6c9ca
Author: tommycli <tommycli@chromium.org>
Date: Wed Aug 24 22:42:50 2016

Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG= 640323 
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2271003003
Cr-Commit-Position: refs/heads/master@{#414181}

[modify] https://crrev.com/3e988531f70d2489982275e0fc26e18f8cc6c9ca/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/3e988531f70d2489982275e0fc26e18f8cc6c9ca/chrome/test/data/webui/settings/route_tests.js

Status: Fixed (was: Assigned)

Sign in to add a comment