New issue
Advanced search Search tips

Issue 640319 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 23 2016

Issue description

"org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub2ZmbGluZXBhZ2VzLk9mZmxpbmVQYWdlVXRpbHNUZXN0I3Rlc3RDb3B5VG9TaGFyZWFibGVMb2NhdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Aug 25 2016

Detected 7 new flakes for test/step "org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub2ZmbGluZXBhZ2VzLk9mZmxpbmVQYWdlVXRpbHNUZXN0I3Rlc3RDb3B5VG9TaGFyZWFibGVMb2NhdGlvbgw. This message was posted automatically by the chromium-try-flakes app.
Test code line:
https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java?rcl=0&l=274

Error:
org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation (run #1):
junit.framework.AssertionFailedError: File copy result incorrect expected:<754> but was:<0>
	at org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest.testCopyToShareableLocation(OfflinePageUtilsTest.java:274)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation (run #2):
junit.framework.AssertionFailedError: The shareable offline page file should not already exist.
	at org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest.testCopyToShareableLocation(OfflinePageUtilsTest.java:265)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation (run #3):
junit.framework.AssertionFailedError: The shareable offline page file should not already exist.
	at org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest.testCopyToShareableLocation(OfflinePageUtilsTest.java:265)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Labels: -Sheriff-Chromium
Owner: fgor...@chromium.org
Status: Assigned (was: Untriaged)
Filip: this test was added in commit be3aae7 on "2016-08-17 22:11:34".  It seems to be flaky.  Can you please take a look?  If you can't find a solution soon please disable the test or revert the change.  Thanks.

https://chromium.googlesource.com/chromium/src/+/be3aae7913a59268351546d2a17686fd5a79371a


Components: UI>Browser>Offline
Labels: -Pri-1 OS-Android Pri-2
I'll look into this after branch point.
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Aug 31 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest#testCopyToShareableLocation". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub2ZmbGluZXBhZ2VzLk9mZmxpbmVQYWdlVXRpbHNUZXN0I3Rlc3RDb3B5VG9TaGFyZWFibGVMb2NhdGlvbgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 6 by battre@chromium.org, Aug 31 2016

Components: Tests>Disabled
I am going to disable the test for the time being.

Comment 7 by battre@chromium.org, Aug 31 2016

Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0236c8faaa4fdad9557714c32fe02ff75620b5e3

commit 0236c8faaa4fdad9557714c32fe02ff75620b5e3
Author: battre <battre@chromium.org>
Date: Wed Aug 31 10:12:08 2016

Disabled flaky OfflinePageUtilsTest.testCopyToShareableLocation

BUG= 640319 
TBR=fgorski@chromium.org

Review-Url: https://codereview.chromium.org/2300563002
Cr-Commit-Position: refs/heads/master@{#415599}

[modify] https://crrev.com/0236c8faaa4fdad9557714c32fe02ff75620b5e3/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81804dcb67f03f8852af065bfc3be224bb68c2d5

commit 81804dcb67f03f8852af065bfc3be224bb68c2d5
Author: fgorski <fgorski@chromium.org>
Date: Wed Aug 31 22:30:55 2016

[Offline pages] Reenabling sharing tests

This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation
to make it more reliable (by ensuring a more proper clean up).

BUG= 640319 

patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1)

Review-Url: https://codereview.chromium.org/2303443002
Cr-Commit-Position: refs/heads/master@{#415784}

[modify] https://crrev.com/81804dcb67f03f8852af065bfc3be224bb68c2d5/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment