New issue
Advanced search Search tips

Issue 640310 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

RenderWidget::WillBeginMainFrame should not flush the rendering pipeline

Project Member Reported by dglazkov@chromium.org, Aug 23 2016

Issue description

Currently, this happens by ways of WebViewImpl::textInputInfo. This is clearly wrong, but I don't understand the purpose of the RenderWidget::UpdateTextInputState enough to articulate the solution. In any case, this should not be happening.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa7d9e29b66032b9289769d2948c2b8a394ed4b0

commit aa7d9e29b66032b9289769d2948c2b8a394ed4b0
Author: dglazkov <dglazkov@chromium.org>
Date: Tue Aug 30 23:09:49 2016

Move text/selection update to the back of pipeline

Instead of forcing the spurious rendering pipeline flush to get an updated selection and text input information (for IME), do after the layout and style information had updated.

BUG=640310

Review-Url: https://codereview.chromium.org/2267933002
Cr-Commit-Position: refs/heads/master@{#415483}

[modify] https://crrev.com/aa7d9e29b66032b9289769d2948c2b8a394ed4b0/content/renderer/render_widget.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06854c5cf06608c8491ff2606eecf5760370fec7

commit 06854c5cf06608c8491ff2606eecf5760370fec7
Author: dglazkov <dglazkov@chromium.org>
Date: Wed Aug 31 00:19:59 2016

Revert of Move text/selection update to the back of pipeline (patchset #3 id:40001 of https://codereview.chromium.org/2267933002/ )

Reason for revert:
Need to do more testing/thinking.

Original issue's description:
> Move text/selection update to the back of pipeline
>
> Instead of forcing the spurious rendering pipeline flush to get an updated selection and text input information (for IME), do after the layout and style information had updated.
>
> BUG=640310
>
> Committed: https://crrev.com/aa7d9e29b66032b9289769d2948c2b8a394ed4b0
> Cr-Commit-Position: refs/heads/master@{#415483}

TBR=chrishtr@chromium.org,esprehn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640310

Review-Url: https://codereview.chromium.org/2295013002
Cr-Commit-Position: refs/heads/master@{#415509}

[modify] https://crrev.com/06854c5cf06608c8491ff2606eecf5760370fec7/content/renderer/render_widget.cc

Components: Blink>Internals
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment